diff mbox

[net-next] net: nlmon: flag nlmon devs with LLTX/SG

Message ID 1395934499-29092-1-git-send-email-dborkman@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Daniel Borkmann March 27, 2014, 3:34 p.m. UTC
As in xmit path we merely update statistics and free the skb, we
can mark the device with LLTX feature, so that upper layers can
avoid taking the single txq lock on xmit. While at it, also add
missing NETIF_F_SG.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
 drivers/net/nlmon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eric Dumazet March 27, 2014, 4:09 p.m. UTC | #1
On Thu, 2014-03-27 at 16:34 +0100, Daniel Borkmann wrote:
> As in xmit path we merely update statistics and free the skb, we
> can mark the device with LLTX feature, so that upper layers can
> avoid taking the single txq lock on xmit. While at it, also add
> missing NETIF_F_SG.
> 
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
>  drivers/net/nlmon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Eric Dumazet <edumazet@google.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller March 28, 2014, 8:50 p.m. UTC | #2
From: Daniel Borkmann <dborkman@redhat.com>
Date: Thu, 27 Mar 2014 16:34:59 +0100

> As in xmit path we merely update statistics and free the skb, we
> can mark the device with LLTX feature, so that upper layers can
> avoid taking the single txq lock on xmit. While at it, also add
> missing NETIF_F_SG.
> 
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c
index 6929b03..34924df 100644
--- a/drivers/net/nlmon.c
+++ b/drivers/net/nlmon.c
@@ -136,7 +136,8 @@  static void nlmon_setup(struct net_device *dev)
 	dev->ethtool_ops = &nlmon_ethtool_ops;
 	dev->destructor	= free_netdev;
 
-	dev->features = NETIF_F_FRAGLIST | NETIF_F_HIGHDMA;
+	dev->features = NETIF_F_SG | NETIF_F_FRAGLIST |
+			NETIF_F_HIGHDMA | NETIF_F_LLTX;
 	dev->flags = IFF_NOARP;
 
 	/* That's rather a softlimit here, which, of course,