From patchwork Thu Mar 27 14:30:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 334350 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id C4939140094 for ; Fri, 28 Mar 2014 01:30:27 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WTBK4-0000qd-MT; Thu, 27 Mar 2014 14:30:24 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1WTBJz-0000qS-0U for fwts-devel@lists.ubuntu.com; Thu, 27 Mar 2014 14:30:19 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginm.net ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1WTBJy-0005gq-UB for fwts-devel@lists.ubuntu.com; Thu, 27 Mar 2014 14:30:18 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] fwts_acpica: fix potential null ptr dereference (LP: #1298419) Date: Thu, 27 Mar 2014 14:30:18 +0000 Message-Id: <1395930618-17941-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.9.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King smatch detected a potential null ptr dereference issue, we should ensure that buffer is allocated before scan it with index(). Signed-off-by: Colin Ian King Acked-by: Alex Hung Acked-by: Ivan Hu --- src/acpica/fwts_acpica.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c index 9d92470..cc691c3 100644 --- a/src/acpica/fwts_acpica.c +++ b/src/acpica/fwts_acpica.c @@ -440,7 +440,7 @@ void fwts_acpica_vprintf(const char *fmt, va_list args) } } - if (index(buffer, '\n') != NULL) { + if (buffer_len && index(buffer, '\n') != NULL) { fwts_log_info(fwts_acpica_fw, "%s", buffer); free(buffer); buffer_len = 0;