Patchwork [x86,testsuite,AVX-512] Fix initialization in 4 tests for shuffles.

login
register
mail settings
Submitter Kirill Yukhin
Date March 27, 2014, 9:18 a.m.
Message ID <20140327091847.GA47607@msticlxl57.ims.intel.com>
Download mbox | patch
Permalink /patch/334257/
State New
Headers show

Comments

Kirill Yukhin - March 27, 2014, 9:18 a.m.
Hello,
Straightforward patch in the bottom fixes
copy-and-paste problem in initialization part
of tests.

Updated tests pass on simulator.

Is it ok for trunk?

gcc/testsuite:
	* gcc.target/i386/avx512f-vshuff32x4-2.c: Fix initialization
	of second source operand.
	* gcc.target/i386/avx512f-vshuff64x2-2.c: Ditto.
	* gcc.target/i386/avx512f-vshufi32x4-2.c: Ditto.
	* gcc.target/i386/avx512f-vshufi64x2-2.c: Ditto.

--
Thanks, K

PS: I fully understand that there should be lots
of such bugs in testsuite and going to fix them all.

commit 2a5c128e75b4f18189d62b0e159de73272c41cf9
Author: Kirill Yukhin <kirill.yukhin@intel.com>
Date:   Thu Mar 27 13:04:15 2014 +0400

    AVX-512. Fix initialization of AVX-512 shuffle tests.
---
 gcc/testsuite/gcc.target/i386/avx512f-vshuff32x4-2.c | 2 +-
 gcc/testsuite/gcc.target/i386/avx512f-vshuff64x2-2.c | 2 +-
 gcc/testsuite/gcc.target/i386/avx512f-vshufi32x4-2.c | 2 +-
 gcc/testsuite/gcc.target/i386/avx512f-vshufi64x2-2.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
Uros Bizjak - March 27, 2014, 9:38 a.m.
On Thu, Mar 27, 2014 at 10:18 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:

> Straightforward patch in the bottom fixes
> copy-and-paste problem in initialization part
> of tests.
>
> Updated tests pass on simulator.
>
> Is it ok for trunk?
>
> gcc/testsuite:
>         * gcc.target/i386/avx512f-vshuff32x4-2.c: Fix initialization
>         of second source operand.
>         * gcc.target/i386/avx512f-vshuff64x2-2.c: Ditto.
>         * gcc.target/i386/avx512f-vshufi32x4-2.c: Ditto.
>         * gcc.target/i386/avx512f-vshufi64x2-2.c: Ditto.

OK.

Thanks,
Uros.

Patch

diff --git a/gcc/testsuite/gcc.target/i386/avx512f-vshuff32x4-2.c b/gcc/testsuite/gcc.target/i386/avx512f-vshuff32x4-2.c
index 271c862..35eabc2 100644
--- a/gcc/testsuite/gcc.target/i386/avx512f-vshuff32x4-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512f-vshuff32x4-2.c
@@ -43,7 +43,7 @@  TEST (void)
   for (i = 0; i < SIZE; i++)
     {
       s1.a[i] = 1.2 / (i + 0.378);
-      s1.a[i] = 91.02 / (i + 4.3578);
+      s2.a[i] = 91.02 / (i + 4.3578);
       u1.a[i] = DEFAULT_VALUE;
       u2.a[i] = DEFAULT_VALUE;
       u3.a[i] = DEFAULT_VALUE;
diff --git a/gcc/testsuite/gcc.target/i386/avx512f-vshuff64x2-2.c b/gcc/testsuite/gcc.target/i386/avx512f-vshuff64x2-2.c
index 4842942..9fee420 100644
--- a/gcc/testsuite/gcc.target/i386/avx512f-vshuff64x2-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512f-vshuff64x2-2.c
@@ -43,7 +43,7 @@  TEST (void)
   for (i = 0; i < SIZE; i++)
     {
       s1.a[i] = 1.2 / (i + 0.378);
-      s1.a[i] = 91.02 / (i + 4.3578);
+      s2.a[i] = 91.02 / (i + 4.3578);
       u1.a[i] = DEFAULT_VALUE;
       u2.a[i] = DEFAULT_VALUE;
       u3.a[i] = DEFAULT_VALUE;
diff --git a/gcc/testsuite/gcc.target/i386/avx512f-vshufi32x4-2.c b/gcc/testsuite/gcc.target/i386/avx512f-vshufi32x4-2.c
index 105c715..9b1603c 100644
--- a/gcc/testsuite/gcc.target/i386/avx512f-vshufi32x4-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512f-vshufi32x4-2.c
@@ -43,7 +43,7 @@  TEST (void)
   for (i = 0; i < SIZE; i++)
     {
       s1.a[i] = 1.2 / (i + 0.378);
-      s1.a[i] = 91.02 / (i + 4.3578);
+      s2.a[i] = 91.02 / (i + 4.3578);
       u1.a[i] = DEFAULT_VALUE;
       u2.a[i] = DEFAULT_VALUE;
       u3.a[i] = DEFAULT_VALUE;
diff --git a/gcc/testsuite/gcc.target/i386/avx512f-vshufi64x2-2.c b/gcc/testsuite/gcc.target/i386/avx512f-vshufi64x2-2.c
index d79d8f6..85a5918 100644
--- a/gcc/testsuite/gcc.target/i386/avx512f-vshufi64x2-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512f-vshufi64x2-2.c
@@ -43,7 +43,7 @@  TEST (void)
   for (i = 0; i < SIZE; i++)
     {
       s1.a[i] = 1.2 / (i + 0.378);
-      s1.a[i] = 91.02 / (i + 4.3578);
+      s2.a[i] = 91.02 / (i + 4.3578);
       u1.a[i] = DEFAULT_VALUE;
       u2.a[i] = DEFAULT_VALUE;
       u3.a[i] = DEFAULT_VALUE;