diff mbox

[U-Boot,03/10] exynos5: Enable tps65090 on smdk5250

Message ID 1395856590-21917-4-git-send-email-sjg@chromium.org
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Simon Glass March 26, 2014, 5:56 p.m. UTC 
From: Aaron Durbin <adurbin@chromium.org>

The TPS65090 pmic chip can be on exynos5250 boards. Therefore,
select the appropriate config option for TPS65090 devices.

This commit should really use exynos5-dt.c, when it is available.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

 include/configs/exynos5-dt.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Ajay kumar March 29, 2014, 10:40 p.m. UTC | #1 
Hi,

The patch name, kind of gives wrong impression.
There is no TPS65090 device on SMDK5250.
TPS65090 is present only on snow board based on exynos5250.
Please change it!


On Wed, Mar 26, 2014 at 11:26 PM, Simon Glass <sjg@chromium.org> wrote:

> From: Aaron Durbin <adurbin@chromium.org>
>
> The TPS65090 pmic chip can be on exynos5250 boards. Therefore,
> select the appropriate config option for TPS65090 devices.
>
> This commit should really use exynos5-dt.c, when it is available.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
>  include/configs/exynos5-dt.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/exynos5-dt.h b/include/configs/exynos5-dt.h
> index 414db42..fbf09f5 100644
> --- a/include/configs/exynos5-dt.h
> +++ b/include/configs/exynos5-dt.h
> @@ -259,6 +259,7 @@
>  /* PMIC */
>  #define CONFIG_POWER
>  #define CONFIG_POWER_I2C
> +#define CONFIG_POWER_TPS65090
>
>  /* Ethernet Controllor Driver */
>  #ifdef CONFIG_CMD_NET
> --
> 1.9.1.423.g4596e3a
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Regards,
Ajay Kumar
Simon Glass March 30, 2014, 12:22 a.m. UTC | #2 
Hi Ajay,

On 29 March 2014 16:40, Ajay kumar <ajaynumb@gmail.com> wrote:

> Hi,
>
> The patch name, kind of gives wrong impression.
> There is no TPS65090 device on SMDK5250.
> TPS65090 is present only on snow board based on exynos5250.
> Please change it!
>

Will do.

Regards,
Simon
diff mbox

Patch

diff --git a/include/configs/exynos5-dt.h b/include/configs/exynos5-dt.h
index 414db42..fbf09f5 100644
--- a/include/configs/exynos5-dt.h
+++ b/include/configs/exynos5-dt.h
@@ -259,6 +259,7 @@ 
 /* PMIC */
 #define CONFIG_POWER
 #define CONFIG_POWER_I2C
+#define CONFIG_POWER_TPS65090
 
 /* Ethernet Controllor Driver */
 #ifdef CONFIG_CMD_NET