From patchwork Tue Mar 25 19:26:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 333689 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 28511140081 for ; Wed, 26 Mar 2014 06:27:43 +1100 (EST) Received: from localhost ([::1]:43822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSX0f-00054V-5Y for incoming@patchwork.ozlabs.org; Tue, 25 Mar 2014 15:27:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSX07-0004x8-IK for qemu-devel@nongnu.org; Tue, 25 Mar 2014 15:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WSX02-0000N2-9K for qemu-devel@nongnu.org; Tue, 25 Mar 2014 15:27:07 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WSX02-0000J0-30 for qemu-devel@nongnu.org; Tue, 25 Mar 2014 15:27:02 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WSWzt-00084G-5P; Tue, 25 Mar 2014 19:26:53 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 25 Mar 2014 19:26:52 +0000 Message-Id: <1395775613-30984-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395775613-30984-1-git-send-email-peter.maydell@linaro.org> References: <1395775613-30984-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Paolo Bonzini , patches@linaro.org Subject: [Qemu-devel] [maybe-for-2.0 1/2] hw/arm: Stop specifying integratorcp as the default board X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Currently for both qemu-system-arm and qemu-system-aarch64 the default board model if the user doesn't specify one is the 'integratorcp'. This is a totally arbitrary historical accident since it was the first board to be modelled. That board is now just one target among many for us, and is a very poor choice of default: * it's an ancient board that is now only found in the junkpiles of longtime ARM/Linux hackers, if at all * it's an ARMv5 CPU, when most distros are now assuming ARMv7 * it's pretty much unmaintained in QEMU * it doesn't even have versatilepb's advantage of supporting PCI Making it or any other board the default serves only to confuse people new to ARM who expect something more like the x86 monoculture. Remove the is_default marker from integratorcp, and don't set it for any other board, to give users a nudge that they need to think about which board they want a QEMU model of. (QEMU will produce the admittedly slightly cryptic error "No machine found.") Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- hw/arm/integratorcp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index a759689..912af96 100644 --- a/hw/arm/integratorcp.c +++ b/hw/arm/integratorcp.c @@ -534,7 +534,6 @@ static QEMUMachine integratorcp_machine = { .name = "integratorcp", .desc = "ARM Integrator/CP (ARM926EJ-S)", .init = integratorcp_init, - .is_default = 1, }; static void integratorcp_machine_init(void)