| Message ID | 0578e818bb81d98a0595d16389d5bb585ce87739.1395757728.git.kibo@prevas.dk |
|---|---|
| State | Accepted |
| Headers | show |
Hi Kim How is this a preparation for removal? Kim Bøndergaard <kibo@prevas.dk> writes: > --- > recipes/atk/atk.inc | 7 +++++-- > recipes/atk/atk_2.2.0.oe | 2 ++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/recipes/atk/atk.inc b/recipes/atk/atk.inc > index 78590ae..dac4e1b 100644 > --- a/recipes/atk/atk.inc > +++ b/recipes/atk/atk.inc > @@ -1,11 +1,14 @@ > +SUMMARY = "ATK, Provides a set of interfaces for accessibility." > DESCRIPTION = "ATK provides the set of accessibility interfaces that are implemented by other toolkits and applications." > LICENSE = "LGPL-2.1" > > RECIPE_TYPES = "machine native" > > -DEPENDS = "libgthread libgobject libgmodule libgio native:glib-utils gtk-doc" > > inherit autotools-autoreconf library pkgconfig > > -DEPENDS_${PN} += "${DEPENDS}" > +DEPENDS += "glib-libgobject" Why are you addoing glib-libgobject instead of libgobject? You normally (read as always) should add the library name/provide, and not the package name to DEPENDS. > +DEPENDS_${PN} += "libc libffi libglib libgobject libgthread libpcre libpthread" > +RDEPENDS_${PN} += "libc libffi libglib libgobject libgthread libpcre libpthread" > + > FILES_${PN}-doc += "${datadir}/gtk-doc" > diff --git a/recipes/atk/atk_2.2.0.oe b/recipes/atk/atk_2.2.0.oe > index e14eafe..6811d08 100644 > --- a/recipes/atk/atk_2.2.0.oe > +++ b/recipes/atk/atk_2.2.0.oe > @@ -2,3 +2,5 @@ require atk.inc > > SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/atk/2.2/${PN}-${PV}.tar.xz" > SRC_URI += "file://mingw.patch" > + > +DEPENDS = "libgthread libgobject libgmodule libgio native:glib-utils" Why are you making these DEPENDS version specific? And why does it make sense to do that, while keeping the same package dependencies in the .inc file? /Esben
diff --git a/recipes/atk/atk.inc b/recipes/atk/atk.inc index 78590ae..dac4e1b 100644 --- a/recipes/atk/atk.inc +++ b/recipes/atk/atk.inc @@ -1,11 +1,14 @@ +SUMMARY = "ATK, Provides a set of interfaces for accessibility." DESCRIPTION = "ATK provides the set of accessibility interfaces that are implemented by other toolkits and applications." LICENSE = "LGPL-2.1" RECIPE_TYPES = "machine native" -DEPENDS = "libgthread libgobject libgmodule libgio native:glib-utils gtk-doc" inherit autotools-autoreconf library pkgconfig -DEPENDS_${PN} += "${DEPENDS}" +DEPENDS += "glib-libgobject" +DEPENDS_${PN} += "libc libffi libglib libgobject libgthread libpcre libpthread" +RDEPENDS_${PN} += "libc libffi libglib libgobject libgthread libpcre libpthread" + FILES_${PN}-doc += "${datadir}/gtk-doc" diff --git a/recipes/atk/atk_2.2.0.oe b/recipes/atk/atk_2.2.0.oe index e14eafe..6811d08 100644 --- a/recipes/atk/atk_2.2.0.oe +++ b/recipes/atk/atk_2.2.0.oe @@ -2,3 +2,5 @@ require atk.inc SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/atk/2.2/${PN}-${PV}.tar.xz" SRC_URI += "file://mingw.patch" + +DEPENDS = "libgthread libgobject libgmodule libgio native:glib-utils"