From patchwork Thu Sep 10 15:18:45 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark McLoughlin X-Patchwork-Id: 33326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 24D59B70AD for ; Fri, 11 Sep 2009 01:35:41 +1000 (EST) Received: from localhost ([127.0.0.1]:58028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MllgQ-0001V3-G6 for incoming@patchwork.ozlabs.org; Thu, 10 Sep 2009 11:35:38 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MllXx-0006GQ-Vy for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MllXs-0006Ch-16 for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:52 -0400 Received: from [199.232.76.173] (port=40177 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MllXr-0006Ca-RV for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:47 -0400 Received: from mail25.svc.cra.dublin.eircom.net ([159.134.118.54]:45356) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MllXq-00007C-2e for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:46 -0400 Received: (qmail 8337 messnum 1083257 invoked from network[83.71.108.236/83-71-108-236-dynamic.b-ras1.srl.dublin.eircom.net]); 10 Sep 2009 15:20:04 -0000 Received: from 83-71-108-236-dynamic.b-ras1.srl.dublin.eircom.net (HELO blaa.localdomain) (83.71.108.236) by mail25.svc.cra.dublin.eircom.net (qp 8337) with SMTP; 10 Sep 2009 15:20:04 -0000 Received: by blaa.localdomain (Postfix, from userid 500) id 64AC541A8B; Thu, 10 Sep 2009 16:19:01 +0100 (IST) From: Mark McLoughlin To: qemu-devel@nongnu.org Date: Thu, 10 Sep 2009 16:18:45 +0100 Message-Id: <1252595941-15196-4-git-send-email-markmc@redhat.com> X-Mailer: git-send-email 1.6.2.5 In-Reply-To: <1252595941-15196-1-git-send-email-markmc@redhat.com> References: <1252595941-15196-1-git-send-email-markmc@redhat.com> X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Mark McLoughlin Subject: [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qemu_opt_set() prints an error message in all failure cases, so qemu_set_option() doesn't need to print another error. Signed-off-by: Mark McLoughlin --- qemu-config.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 61e6ed1..733cc24 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -186,11 +186,9 @@ int qemu_set_option(const char *str) return -1; } - if (qemu_opt_set(opts, arg, str+offset+1) == -1) { - fprintf(stderr, "failed to set \"%s\" for %s \"%s\"\n", - arg, lists[i]->name, id); + if (qemu_opt_set(opts, arg, str+offset+1) == -1) return -1; - } + return 0; }