From patchwork Thu Sep 10 11:32:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 33313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id ED71CB7B71 for ; Thu, 10 Sep 2009 21:51:18 +1000 (EST) Received: from localhost ([127.0.0.1]:55083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MliBI-0006L0-3K for incoming@patchwork.ozlabs.org; Thu, 10 Sep 2009 07:51:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mlhtf-0006gc-IG for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:33:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mlhta-0006YR-Qn for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:33:02 -0400 Received: from [199.232.76.173] (port=40452 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mlhta-0006Y6-Fr for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:32:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59976) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mlhta-0003Fe-2p for qemu-devel@nongnu.org; Thu, 10 Sep 2009 07:32:58 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8ABWv8w017565 for ; Thu, 10 Sep 2009 07:32:57 -0400 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8ABWtjL027805 for ; Thu, 10 Sep 2009 07:32:56 -0400 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id 28B1418D467; Thu, 10 Sep 2009 14:32:55 +0300 (IDT) Date: Thu, 10 Sep 2009 14:32:55 +0300 From: Gleb Natapov To: qemu-devel@nongnu.org Message-ID: <20090910113255.GM22885@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] [PATCH] kvm_arch_get_registers() shouldn't be called directly X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Direct call to kvm_arch_get_registers() bypass logic in cpu_synchronize_state() Signed-off-by: Gleb Natapov --- Gleb. diff --git a/target-i386/helper.c b/target-i386/helper.c index 27063e5..8abbed0 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -744,7 +744,7 @@ void cpu_dump_state(CPUState *env, FILE *f, static const char *seg_name[6] = { "ES", "CS", "SS", "DS", "FS", "GS" }; if (kvm_enabled()) - kvm_arch_get_registers(env); + cpu_synchronize_state(env); eflags = env->eflags; #ifdef TARGET_X86_64