Patchwork kvm_arch_get_registers() shouldn't be called directly

login
register
mail settings
Submitter Gleb Natapov
Date Sept. 10, 2009, 11:32 a.m.
Message ID <20090910113255.GM22885@redhat.com>
Download mbox | patch
Permalink /patch/33313/
State Superseded
Headers show

Comments

Gleb Natapov - Sept. 10, 2009, 11:32 a.m.
Direct call to kvm_arch_get_registers() bypass logic in
cpu_synchronize_state()

Signed-off-by: Gleb Natapov <gleb@redhat.com>
--
			Gleb.

Patch

diff --git a/target-i386/helper.c b/target-i386/helper.c
index 27063e5..8abbed0 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -744,7 +744,7 @@  void cpu_dump_state(CPUState *env, FILE *f,
     static const char *seg_name[6] = { "ES", "CS", "SS", "DS", "FS", "GS" };
 
     if (kvm_enabled())
-        kvm_arch_get_registers(env);
+        cpu_synchronize_state(env);
 
     eflags = env->eflags;
 #ifdef TARGET_X86_64