| Message ID | 1395646471-637-1-git-send-email-asuka.com@163.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Wei Zhang <asuka.com@163.com> Date: Mon, 24 Mar 2014 15:34:31 +0800 > When use the gre vport, openvswitch register a gre_cisco_protocol but > does not supply a err_handler with it. The gre_cisco_err() call the > err_handler without existence check, cause the kernel crash. > > This patch base on v3.14-rc7. But the bug affect all kernel newer than > 3.11! > > Signed-off-by: Wei Zhang <asuka.com@163.com> Rather, openvswitch should provide an appropriate ->err_handler() that returns PACKET_RCVD or PACKET_REJECT. I'm not applying this patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
At 2014-03-25 03:14:17,"David Miller" <davem@davemloft.net> wrote: >From: Wei Zhang <asuka.com@163.com> >Date: Mon, 24 Mar 2014 15:34:31 +0800 > >> When use the gre vport, openvswitch register a gre_cisco_protocol but >> does not supply a err_handler with it. The gre_cisco_err() call the >> err_handler without existence check, cause the kernel crash. >> >> This patch base on v3.14-rc7. But the bug affect all kernel newer than >> 3.11! >> >> Signed-off-by: Wei Zhang <asuka.com@163.com> > >Rather, openvswitch should provide an appropriate ->err_handler() that >returns PACKET_RCVD or PACKET_REJECT. Thank you for your explanation, I misunderstand it . I'm very sorry about this bothering! > >I'm not applying this patch.
diff --git a/net/ipv4/gre_demux.c b/net/ipv4/gre_demux.c index 1863422..56b0d67 100644 --- a/net/ipv4/gre_demux.c +++ b/net/ipv4/gre_demux.c @@ -250,7 +250,7 @@ static void gre_cisco_err(struct sk_buff *skb, u32 info) struct gre_cisco_protocol *proto; proto = rcu_dereference(gre_cisco_proto_list[i]); - if (!proto) + if (!proto || !proto->err_handler) continue; if (proto->err_handler(skb, info, &tpi) == PACKET_RCVD)
When use the gre vport, openvswitch register a gre_cisco_protocol but does not supply a err_handler with it. The gre_cisco_err() call the err_handler without existence check, cause the kernel crash. This patch base on v3.14-rc7. But the bug affect all kernel newer than 3.11! Signed-off-by: Wei Zhang <asuka.com@163.com> --- net/ipv4/gre_demux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)