diff mbox

qcow2: Remove FIXME comment, already fixed

Message ID 1395641175-30878-1-git-send-email-deepak.mk17@gmail.com
State New
Headers show

Commit Message

Deepak Kathayat March 24, 2014, 6:06 a.m. UTC 
Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
---
 block/qcow2.h |    1 -
 1 file changed, 1 deletion(-)

Comments

Leandro Dorileo March 24, 2014, 3:08 p.m. UTC | #1 
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote:
> 
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>

Reviewed-by: Leandro Dorileo <l@dorileo.org>

> ---
>  block/qcow2.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 0b0eac8..25663d4 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -413,7 +413,6 @@ static inline uint64_t l2meta_cow_end(QCowL2Meta *m)
>          + (m->cow_end.nb_sectors << BDRV_SECTOR_BITS);
>  }
>  
> -// FIXME Need qcow2_ prefix to global functions
>  
>  /* qcow2.c functions */
>  int qcow2_backing_read1(BlockDriverState *bs, QEMUIOVector *qiov,
> -- 
> 1.7.9.5
> 
>
Stefan Hajnoczi March 25, 2014, 12:47 p.m. UTC | #2 
On Mon, Mar 24, 2014 at 02:06:15PM +0800, Deepak Kathayat wrote:
> 
> Signed-off-by: Deepak Kathayat <deepak.mk17@gmail.com>
> ---
>  block/qcow2.h |    1 -
>  1 file changed, 1 deletion(-)

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan
diff mbox

Patch

diff --git a/block/qcow2.h b/block/qcow2.h
index 0b0eac8..25663d4 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -413,7 +413,6 @@  static inline uint64_t l2meta_cow_end(QCowL2Meta *m)
         + (m->cow_end.nb_sectors << BDRV_SECTOR_BITS);
 }
 
-// FIXME Need qcow2_ prefix to global functions
 
 /* qcow2.c functions */
 int qcow2_backing_read1(BlockDriverState *bs, QEMUIOVector *qiov,