From patchwork Sun Mar 23 11:22:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 332882 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7EE022C00BA for ; Sun, 23 Mar 2014 22:32:27 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=R1MNLyPJLY+y8e58 66WxXABd+9/Am10b7REtYZvuUOkL0wDlOB2TGB4D+be2pwOsjEKytdibZMl76hKF uWPPxlOtjjnnEPK6a4WXRxOuU77nZYzzixkOoXkNN8zVrbXXSy6tf9OCQdfURFxP X9l7e4RsVGI3AFuktI9aSgEbRCk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=9KKm2O7PxeDo9gjiCnIMLD h9D/0=; b=us9tmcN+hz+4/9pCUS+XPfyJXIcooQKbdm6JY1fVylGgT+PnmejaHK Kbq2TdFBWBv18/e2Ll751ojD/1/qGUNWLKBlQVaoZs1tTYf2Q5+5ehCEGKkdPNTk MXt5I5Jn0D5DsUYsjw5OGwSKF1pum34vasH7o91heVXw5A/IvNpRQ= Received: (qmail 7291 invoked by alias); 23 Mar 2014 11:32:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7272 invoked by uid 89); 23 Mar 2014 11:32:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 23 Mar 2014 11:32:10 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id F0E8C2709D60 for ; Sun, 23 Mar 2014 12:32:06 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fT6eu4keDVyQ for ; Sun, 23 Mar 2014 12:32:06 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id D6C0F2709D32 for ; Sun, 23 Mar 2014 12:32:06 +0100 (CET) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: Fix PR rtl-optimization/60601 Date: Sun, 23 Mar 2014 12:22:24 +0100 Message-ID: <14244973.FZEsiV2GuH@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) MIME-Version: 1.0 This is the profiled bootstrap failure on the mainline with Ada enabled and comes from a pasto in fix_up_fall_thru_edges, which tests EDGE_FALLTHRU to detect falltrugh edges when there are at most 2 outgoing edges but switches to EDGE_CAN_FALLTHRU when there are more than 2 outgoing edges. Now this latter flag is never set during the bbpart pass but only during bbro. The gcc.c hunk silences a fatal -Wmaybe-uninitialized warning on the mainline. Profiledbootstrapped/regtested on x86_64-suse-linux, applied on all active branches, as obvious for the gcc.c hunk. 2014-03-23 Eric Botcazou PR rtl-optimization/60601 * bb-reorder.c (fix_up_fall_thru_edges): Test EDGE_FALLTHRU everywhere. * gcc.c (eval_spec_function): Initialize save_growing_value. Index: bb-reorder.c =================================================================== --- bb-reorder.c (revision 208763) +++ bb-reorder.c (working copy) @@ -1826,9 +1826,8 @@ fix_up_fall_thru_edges (void) edge e; edge_iterator ei; - /* Find EDGE_CAN_FALLTHRU edge. */ FOR_EACH_EDGE (e, ei, cur_bb->succs) - if (e->flags & EDGE_CAN_FALLTHRU) + if (e->flags & EDGE_FALLTHRU) { fall_thru = e; break; Index: gcc.c =================================================================== --- gcc.c (revision 208763) +++ gcc.c (working copy) @@ -5481,7 +5481,7 @@ eval_spec_function (const char *func, co const char *save_suffix_subst; int save_growing_size; - void *save_growing_value; + void *save_growing_value = NULL; sf = lookup_spec_function (func); if (sf == NULL)