Patchwork [v3] mtd: m25p80: Modify the name of mtd_info

login
register
mail settings
Submitter Zhiqiang Hou
Date March 22, 2014, 8:55 a.m.
Message ID <1395478518-22308-1-git-send-email-B48286@freescale.com>
Download mbox | patch
Permalink /patch/332819/
State Not Applicable
Headers show

Comments

Zhiqiang Hou - March 22, 2014, 8:55 a.m.
To specify spi flash layouts by "mtdparts=..." in cmdline, we must
give mtd_info a fixed name,because the cmdlinepart's parser will
match the name of mtd_info given in cmdline.
Now, if use DT, the mtd_info's name will be spi->dev->name. It
consists of spi_master->bus_num, and the spi_master->bus_num maybe
dynamically fetched. So, in this case, replace the component bus_num
with thei physical address of spi master.

Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
---
v3:
	Fix a bug, matching unsigned long long with "%llx".
v2:
	1. Fix some code style issue.
	2. Cast physical address to unsigned long long.

 drivers/mtd/devices/m25p80.c | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)
Brian Norris - April 16, 2014, 6:53 a.m.
On Sat, Mar 22, 2014 at 1:55 AM, Hou Zhiqiang <B48286@freescale.com> wrote:
> v3:
>         Fix a bug, matching unsigned long long with "%llx".
> v2:
>         1. Fix some code style issue.
>         2. Cast physical address to unsigned long long.

I missed v2 and v3 and commented on v1 instead, sorry. Same comments
apply here though.

Also, can you please include PATCH in the subject? (e.g., [PATCH v3])
See Documentation/SubmittingPatches, item 11.

Thanks,
Brian

Patch

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 7eda71d..695890e 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -30,6 +30,7 @@ 
 #include <linux/mtd/cfi.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/partitions.h>
+#include <linux/of_address.h>
 #include <linux/of_platform.h>
 
 #include <linux/spi/spi.h>
@@ -934,9 +935,11 @@  static int m25p_probe(struct spi_device *spi)
 	struct flash_platform_data	*data;
 	struct m25p			*flash;
 	struct flash_info		*info;
-	unsigned			i;
+	unsigned			i, ret;
 	struct mtd_part_parser_data	ppdata;
 	struct device_node *np = spi->dev.of_node;
+	struct resource res;
+	struct device_node *mnp = spi->master->dev.of_node;
 
 	/* Platform data helps sort out which chip type we have, as
 	 * well as how this board partitions it.  If we don't have
@@ -1009,8 +1012,18 @@  static int m25p_probe(struct spi_device *spi)
 
 	if (data && data->name)
 		flash->mtd.name = data->name;
-	else
-		flash->mtd.name = dev_name(&spi->dev);
+	else {
+		ret = of_address_to_resource(mnp, 0, &res);
+		if (ret) {
+			dev_err(&spi->dev, "failed to get spi master resource\n");
+			return ret;
+		}
+		flash->mtd.name = kasprintf(GFP_KERNEL, "spi%llx.%d",
+				(unsigned long long)res.start,
+				spi->chip_select);
+		if (!flash->mtd.name)
+			return -ENOMEM;
+	}
 
 	flash->mtd.type = MTD_NORFLASH;
 	flash->mtd.writesize = 1;