diff mbox

[v5,1/2] libubox: new package

Message ID 1395353831-7760-1-git-send-email-yegorslists@googlemail.com
State Accepted
Headers show

Commit Message

Yegor Yefremov March 20, 2014, 10:17 p.m. UTC
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
	v5: description rework
        v4: remove unneeded pkg-config macros
        v3: add Lua support
        v2: make package description more informative and fix license information

 package/Config.in          |  1 +
 package/libubox/Config.in  |  9 +++++++++
 package/libubox/libubox.mk | 18 ++++++++++++++++++
 3 files changed, 28 insertions(+)
 create mode 100644 package/libubox/Config.in
 create mode 100644 package/libubox/libubox.mk

Comments

Peter Korsgaard March 23, 2014, 8:21 p.m. UTC | #1
>>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes:

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 > ---
 > Changes:
 > 	v5: description rework
 >         v4: remove unneeded pkg-config macros
 >         v3: add Lua support
 >         v2: make package description more informative and fix license information

 >  package/Config.in          |  1 +
 >  package/libubox/Config.in  |  9 +++++++++
 >  package/libubox/libubox.mk | 18 ++++++++++++++++++
 >  3 files changed, 28 insertions(+)
 >  create mode 100644 package/libubox/Config.in
 >  create mode 100644 package/libubox/libubox.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index f9c1b0b..a2e859c 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -784,6 +784,7 @@ source "package/libsigc/Config.in"
 >  source "package/libsigsegv/Config.in"
 >  source "package/libtasn1/Config.in"
 >  source "package/libtpl/Config.in"
 > +source "package/libubox/Config.in"
 >  source "package/libunwind/Config.in"
 >  source "package/liburcu/Config.in"
 >  source "package/linux-pam/Config.in"
 > diff --git a/package/libubox/Config.in b/package/libubox/Config.in
 > new file mode 100644
 > index 0000000..ba10f8d
 > --- /dev/null
 > +++ b/package/libubox/Config.in
 > @@ -0,0 +1,9 @@
 > +config BR2_PACKAGE_LIBUBOX
 > +	bool "libubox"
 > +	help
 > +	  This library originates from the OpenWrt project to
 > +	  handle the configuration file infrastructure, but can
 > +	  also be used for the same purposes in projects other
 > +	  than OpenWrt.
 > +
 > +	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
 > diff --git a/package/libubox/libubox.mk b/package/libubox/libubox.mk
 > new file mode 100644
 > index 0000000..fe3f420
 > --- /dev/null
 > +++ b/package/libubox/libubox.mk
 > @@ -0,0 +1,18 @@
 > +################################################################################
 > +#
 > +# libubox
 > +#
 > +################################################################################
 > +
 > +LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
 > +LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
 > +LIBUBOX_LICENSE = LGPLv2.1, GPLv2, BSD-3c, MIT
 > +LIBUBOX_INSTALL_STAGING = YES
 > +
 > +ifeq ($(BR2_PACKAGE_LUA),y)
 > +	LIBUBOX_DEPENDENCIES = lua
 > +else
 > +	LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF

It would be nicer to use += in case this ever gets extended.

I see that it unconditionally creates a .so, so it needs to depend on
!BR2_PREFER_STATIC_LIB.

Committed with those fixes, thanks.
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index f9c1b0b..a2e859c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -784,6 +784,7 @@  source "package/libsigc/Config.in"
 source "package/libsigsegv/Config.in"
 source "package/libtasn1/Config.in"
 source "package/libtpl/Config.in"
+source "package/libubox/Config.in"
 source "package/libunwind/Config.in"
 source "package/liburcu/Config.in"
 source "package/linux-pam/Config.in"
diff --git a/package/libubox/Config.in b/package/libubox/Config.in
new file mode 100644
index 0000000..ba10f8d
--- /dev/null
+++ b/package/libubox/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_LIBUBOX
+	bool "libubox"
+	help
+	  This library originates from the OpenWrt project to
+	  handle the configuration file infrastructure, but can
+	  also be used for the same purposes in projects other
+	  than OpenWrt.
+
+	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
diff --git a/package/libubox/libubox.mk b/package/libubox/libubox.mk
new file mode 100644
index 0000000..fe3f420
--- /dev/null
+++ b/package/libubox/libubox.mk
@@ -0,0 +1,18 @@ 
+################################################################################
+#
+# libubox
+#
+################################################################################
+
+LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
+LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
+LIBUBOX_LICENSE = LGPLv2.1, GPLv2, BSD-3c, MIT
+LIBUBOX_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_LUA),y)
+	LIBUBOX_DEPENDENCIES = lua
+else
+	LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
+endif
+
+$(eval $(cmake-package))