diff mbox

[4,of,4] qextserialport: use TARGET_MAKE_ENV when running make and qmake

Message ID caeab58814c94c25ce68.1395257409@argentina
State Accepted
Commit ab310df1887d1d862af287c1353a1e38e99cad6c
Headers show

Commit Message

Thomas De Schampheleire March 19, 2014, 7:30 p.m. UTC
This patch prepends TARGET_MAKE_ENV to $(MAKE) and $(QT_QMAKE) command
lines, to make sure PATH is set correctly, and to line up with the qt5
packages that do this consistently.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 package/qextserialport/qextserialport.mk |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Arnout Vandecappelle March 25, 2014, 10:59 p.m. UTC | #1
On 19/03/14 20:30, Thomas De Schampheleire wrote:
> This patch prepends TARGET_MAKE_ENV to $(MAKE) and $(QT_QMAKE) command
> lines, to make sure PATH is set correctly, and to line up with the qt5
> packages that do this consistently.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 gpsd probably also requires this change.


 Regards,
 Arnout

> 
> ---
>  package/qextserialport/qextserialport.mk |  4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qextserialport/qextserialport.mk b/package/qextserialport/qextserialport.mk
> --- a/package/qextserialport/qextserialport.mk
> +++ b/package/qextserialport/qextserialport.mk
> @@ -15,11 +15,11 @@ QEXTSERIALPORT_DEPENDENCIES = qt
>  QEXTSERIALPORT_INSTALL_STAGING = YES
>  
>  define QEXTSERIALPORT_CONFIGURE_CMDS
> -	(cd $(@D); $(QT_QMAKE))
> +	(cd $(@D); $(TARGET_MAKE_ENV) $(QT_QMAKE))
>  endef
>  
>  define QEXTSERIALPORT_BUILD_CMDS
> -	$(MAKE) -C $(@D)
> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>  endef
>  
>  define QEXTSERIALPORT_INSTALL_STAGING_CMDS
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox

Patch

diff --git a/package/qextserialport/qextserialport.mk b/package/qextserialport/qextserialport.mk
--- a/package/qextserialport/qextserialport.mk
+++ b/package/qextserialport/qextserialport.mk
@@ -15,11 +15,11 @@  QEXTSERIALPORT_DEPENDENCIES = qt
 QEXTSERIALPORT_INSTALL_STAGING = YES
 
 define QEXTSERIALPORT_CONFIGURE_CMDS
-	(cd $(@D); $(QT_QMAKE))
+	(cd $(@D); $(TARGET_MAKE_ENV) $(QT_QMAKE))
 endef
 
 define QEXTSERIALPORT_BUILD_CMDS
-	$(MAKE) -C $(@D)
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
 endef
 
 define QEXTSERIALPORT_INSTALL_STAGING_CMDS