From patchwork Tue Mar 18 09:43:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 331368 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 57EC52C00B0 for ; Tue, 18 Mar 2014 20:44:14 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; q=dns; s=default; b=d4Q9RB9gAE3oRTa3F7LHvxQxKYEW+IVH2krXgo5ajhz qMTOywD2vB2Os2yFz7hfT8JZTeBcsA5QPxhQVqBL3N/O23Ab6+ipQvg/E7yxhzTC Xb/J6OWNWTy1j4wi/HwiONsnU7rsuyZTRvw5565y4GV+VQ9NeMmq2ruE5LZwPbyM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:content-type; s=default; bh=kKFTj+TDIgFlWbudKMU7lahK5mo=; b=OvRM6wiuscX37voII NMzswpZnnVm3hNcKmg2Wj2+GWJdGcOEJ8E4JoaTGnBkIbC6v89fBfhnSUupyd8to 2HCItN8vrDUSt7GJqCVw9SyBYIEfvBg6lEoGpfVw05Auo4CdOQ66BxUaOxO41HP7 5oUAnPV/o1AT57a/J0Qwe92QgY= Received: (qmail 28422 invoked by alias); 18 Mar 2014 09:44:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28413 invoked by uid 89); 18 Mar 2014 09:44:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Mar 2014 09:44:04 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 18 Mar 2014 09:44:02 +0000 Received: from [10.1.209.147] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 18 Mar 2014 09:44:12 +0000 Message-ID: <5328155F.3000603@arm.com> Date: Tue, 18 Mar 2014 09:43:59 +0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org ;" CC: Marcus Shawcroft , Richard Earnshaw Subject: [Patch AArch64] Remove unnecesssary definition of MEMORY_MOVE_COST X-MC-Unique: 114031809440202501 X-IsSubscribed: yes Hi, While looking at something else I realized that we had MEMORY_MOVE_COST defined in the backend. However we also have the more recent target hook defined for this through TARGET_MEMORY_MOVE_COST making it obvious to remove this definition, given that the only use of the macro MEMORY_MOVE_COST is in the default target hook implementation for TARGET_MEMORY_MOVE_COST :) Ok for stage4 ? Just rebuilt the compiler (cc1 and cc1plus), built a few large enough .i files that I had lying around saw no difference in code generated as expected. regards, Ramana Ramana Radhakrishnan * config/aarch64/aarch64.h (MEMORY_MOVE_COST): Delete. diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h index 1f71ee5..7962aa4 100644 --- a/gcc/config/aarch64/aarch64.h +++ b/gcc/config/aarch64/aarch64.h @@ -763,10 +763,6 @@ do { \ /* Put trampolines in the text section so that mapping symbols work correctly. */ #define TRAMPOLINE_SECTION text_section - -/* Costs, etc. */ -#define MEMORY_MOVE_COST(M, CLASS, IN) \ - (GET_MODE_SIZE (M) < 8 ? 8 : GET_MODE_SIZE (M)) /* To start with. */ #define BRANCH_COST(SPEED_P, PREDICTABLE_P) 2