Patchwork [AArch64] Remove unnecesssary definition of MEMORY_MOVE_COST

login
register
mail settings
Submitter Ramana Radhakrishnan
Date March 18, 2014, 9:43 a.m.
Message ID <5328155F.3000603@arm.com>
Download mbox | patch
Permalink /patch/331368/
State New
Headers show

Comments

Ramana Radhakrishnan - March 18, 2014, 9:43 a.m.
Hi,

	While looking at something else I realized that we had MEMORY_MOVE_COST 
defined in the backend. However we also have the more recent target hook 
defined for this through TARGET_MEMORY_MOVE_COST making it obvious to 
remove this definition, given that the only use of the macro 
MEMORY_MOVE_COST is in the default target hook implementation for 
TARGET_MEMORY_MOVE_COST :)

Ok for stage4 ? Just rebuilt the compiler (cc1 and cc1plus), built a few 
large enough .i files that I had lying around saw no difference in code 
generated as expected.

regards,
Ramana

<DATE>  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

	* config/aarch64/aarch64.h (MEMORY_MOVE_COST): Delete.
Marcus Shawcroft - March 18, 2014, 12:19 p.m.
On 18/03/14 09:43, Ramana Radhakrishnan wrote:
> Hi,
>
> 	While looking at something else I realized that we had MEMORY_MOVE_COST
> defined in the backend. However we also have the more recent target hook
> defined for this through TARGET_MEMORY_MOVE_COST making it obvious to
> remove this definition, given that the only use of the macro
> MEMORY_MOVE_COST is in the default target hook implementation for
> TARGET_MEMORY_MOVE_COST :)
>
> Ok for stage4 ? Just rebuilt the compiler (cc1 and cc1plus), built a few
> large enough .i files that I had lying around saw no difference in code
> generated as expected.
>
> regards,
> Ramana
>
> <DATE>  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>
> 	* config/aarch64/aarch64.h (MEMORY_MOVE_COST): Delete.
>

OK, but leave 24 hours for the RM's to object...

/M

Patch

diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
index 1f71ee5..7962aa4 100644
--- a/gcc/config/aarch64/aarch64.h
+++ b/gcc/config/aarch64/aarch64.h
@@ -763,10 +763,6 @@  do {									     \
 /* Put trampolines in the text section so that mapping symbols work
    correctly.  */
 #define TRAMPOLINE_SECTION text_section
-
-/* Costs, etc.  */
-#define MEMORY_MOVE_COST(M, CLASS, IN) \
-  (GET_MODE_SIZE (M) < 8 ? 8 : GET_MODE_SIZE (M))
 
 /* To start with.  */
 #define BRANCH_COST(SPEED_P, PREDICTABLE_P) 2