| Message ID | 532793D4.5090504@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 18 March 2014 00:31, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > Clean up useless 'break' statement after 'return' statement. > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 03/18/2014 08:39 AM, Peter Maydell wrote: > On 18 March 2014 00:31, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> Clean up useless 'break' statement after 'return' statement. >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > thanks > -- PMM > Thank you too.
On Tue, Mar 18, 2014 at 10:31 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > Clean up useless 'break' statement after 'return' statement. > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > target-arm/gdbstub64.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target-arm/gdbstub64.c b/target-arm/gdbstub64.c > index e8a8295..8f3b8d1 100644 > --- a/target-arm/gdbstub64.c > +++ b/target-arm/gdbstub64.c > @@ -32,10 +32,8 @@ int aarch64_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) > switch (n) { > case 31: > return gdb_get_reg64(mem_buf, env->xregs[31]); > - break; > case 32: > return gdb_get_reg64(mem_buf, env->pc); > - break; > case 33: > return gdb_get_reg32(mem_buf, pstate_read(env)); > } > -- > 1.7.9.5 >
On 03/18/2014 01:14 PM, Peter Crosthwaite wrote: > On Tue, Mar 18, 2014 at 10:31 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> > Clean up useless 'break' statement after 'return' statement. >> > >> > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > OK, thanks.
diff --git a/target-arm/gdbstub64.c b/target-arm/gdbstub64.c index e8a8295..8f3b8d1 100644 --- a/target-arm/gdbstub64.c +++ b/target-arm/gdbstub64.c @@ -32,10 +32,8 @@ int aarch64_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n) switch (n) { case 31: return gdb_get_reg64(mem_buf, env->xregs[31]); - break; case 32: return gdb_get_reg64(mem_buf, env->pc); - break; case 33: return gdb_get_reg32(mem_buf, pstate_read(env)); }
Clean up useless 'break' statement after 'return' statement. Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- target-arm/gdbstub64.c | 2 -- 1 file changed, 2 deletions(-)