mbox

[PULL,0/3] gtk fixes.

Message ID 1394790808-27931-1-git-send-email-kraxel@redhat.com
State New
Headers show

Pull-request

git://git.kraxel.org/qemu tags/pull-gtk-2

Message

Gerd Hoffmann March 14, 2014, 9:53 a.m. UTC
Hi,

gtk pull second round, this time a bit shorter as I've dropped the
cleanup patches.  Lesson learned: getting them right so we still
build on all supported gtk2+3 versions isn't that easy.  There is
no reason to rush them, so lets sort that after 2.0 is out of the
door.

please pull,
  Gerd

The following changes since commit 5d92c74f8a1728a202ba9457872ab0f27ff15e81:

  Update version for v2.0-rc0 (2014-03-13 20:08:15 -0700)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/pull-gtk-2

for you to fetch changes up to 67f7b5f60e38020e889de2cc0052d42756d3559c:

  gtk: Don't warp absolute pointer (2014-03-14 10:42:51 +0100)

----------------------------------------------------------------
gtk: two pointer warp bugfixes.
gtk: Allow to activate grab-on-hover from the command line

----------------------------------------------------------------
Cole Robinson (2):
      gtk: Fix mouse warping with gtk3
      gtk: Don't warp absolute pointer

Jan Kiszka (1):
      gtk: Allow to activate grab-on-hover from the command line

 include/ui/console.h |  2 +-
 qemu-options.hx      |  5 +++++
 ui/gtk.c             | 15 +++++++++++++--
 vl.c                 | 22 +++++++++++++++++++++-
 4 files changed, 40 insertions(+), 4 deletions(-)

Comments

Peter Maydell March 14, 2014, 6:19 p.m. UTC | #1
On 14 March 2014 09:53, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> gtk pull second round, this time a bit shorter as I've dropped the
> cleanup patches.  Lesson learned: getting them right so we still
> build on all supported gtk2+3 versions isn't that easy.  There is
> no reason to rush them, so lets sort that after 2.0 is out of the
> door.
>
> please pull,
>   Gerd
>
> The following changes since commit 5d92c74f8a1728a202ba9457872ab0f27ff15e81:
>
>   Update version for v2.0-rc0 (2014-03-13 20:08:15 -0700)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/pull-gtk-2
>
> for you to fetch changes up to 67f7b5f60e38020e889de2cc0052d42756d3559c:
>
>   gtk: Don't warp absolute pointer (2014-03-14 10:42:51 +0100)

Doesn't build if CONFIG_GTK isn't defined:

/root/qemu/vl.c:146:14: error: 'grab_on_hover' defined but not used
[-Werror=unused-variable]


thanks
-- PMM
Gerd Hoffmann March 17, 2014, 1:39 p.m. UTC | #2
Hi,

> Doesn't build if CONFIG_GTK isn't defined:
> 
> /root/qemu/vl.c:146:14: error: 'grab_on_hover' defined but not used
> [-Werror=unused-variable]

Oops.  /me wonders how that escaped my attention, my mingw test build
should have hit this.  Updated pull on the way.

sorry for the trouble,
  Gerd