| Message ID | 4AA1B712.6060900@hp.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Brian, > CC net/netlink/genetlink.o > net/netlink/genetlink.c: In function ‘genl_register_mc_group’: > net/netlink/genetlink.c:139: warning: ‘err’ may be used uninitialized in this function > > From following the code 'err' is initialized, but set it to zero to > silence the warning. > > Signed-off-by: Brian Haley <brian.haley@hp.com> > --- > > diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c > index 575c643..66f6ba0 100644 > --- a/net/netlink/genetlink.c > +++ b/net/netlink/genetlink.c > @@ -136,7 +136,7 @@ int genl_register_mc_group(struct genl_family *family, > { > int id; > unsigned long *new_groups; > - int err; > + int err = 0; > > BUG_ON(grp->name[0] == '\0'); can we please add the err = -E... where it actually is needed and not stupidly go ahead and silence compiler warnings with err = 0. This has been posted before. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Marcel Holtmann <marcel@holtmann.org> Date: Sat, 05 Sep 2009 03:08:01 +0200 > can we please add the err = -E... where it actually is needed and not > stupidly go ahead and silence compiler warnings with err = 0. This has > been posted before. Ummm, no. Actually Brian's patch is correct. I can't even prove that there are no paths where err won't be initialized properly to something. And if such an occurance happens, returning "0" is absolutely the right thing to do. And that's what Brian's patch does. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 575c643..66f6ba0 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -136,7 +136,7 @@ int genl_register_mc_group(struct genl_family *family, { int id; unsigned long *new_groups; - int err; + int err = 0; BUG_ON(grp->name[0] == '\0'); -- To unsubscribe from this list: send the line "unsubscribe netdev" in
CC net/netlink/genetlink.o net/netlink/genetlink.c: In function ‘genl_register_mc_group’: net/netlink/genetlink.c:139: warning: ‘err’ may be used uninitialized in this function From following the code 'err' is initialized, but set it to zero to silence the warning. Signed-off-by: Brian Haley <brian.haley@hp.com> --- the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html