Patchwork [TRUSTY] intel_pstate: inform user that thermald is worth considering

login
register
mail settings
Submitter Colin King
Date March 13, 2014, 5 p.m.
Message ID <1394730035-7882-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/330040/
State New
Headers show

Comments

Colin King - March 13, 2014, 5 p.m.
From: Colin Ian King <colin.king@canonical.com>

When intel_pstate is enabled with the override intel_pstate=enable
it is also useful to inform the user to also consider installing
thermald for some improved thermal control.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/cpufreq/intel_pstate.c | 2 ++
 1 file changed, 2 insertions(+)
Colin King - March 14, 2014, 8:07 a.m.
Ignore this, I forgot the UBUNTU SAUCE subject line boiler plate

On 13/03/14 17:00, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> When intel_pstate is enabled with the override intel_pstate=enable
> it is also useful to inform the user to also consider installing
> thermald for some improved thermal control.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/cpufreq/intel_pstate.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 7b41d48..80c90c5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -983,6 +983,8 @@ static int __init intel_pstate_init(void)
>  	intel_pstate_debug_expose_params();
>  	intel_pstate_sysfs_expose_params();
>  
> +	pr_info("Consider also installing thermald for improved thermal control.\n");
> +
>  	return rc;
>  out:
>  	get_online_cpus();
>

Patch

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 7b41d48..80c90c5 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -983,6 +983,8 @@  static int __init intel_pstate_init(void)
 	intel_pstate_debug_expose_params();
 	intel_pstate_sysfs_expose_params();
 
+	pr_info("Consider also installing thermald for improved thermal control.\n");
+
 	return rc;
 out:
 	get_online_cpus();