Patchwork [net-next,10/14] ipv6: ICMP6MSGIN_INC_STATS is not used

login
register
mail settings
Submitter Denis V. Lunev
Date Oct. 8, 2008, 11:51 a.m.
Message ID <1223466722-8169-10-git-send-email-den@openvz.org>
Download mbox | patch
Permalink /patch/3297/
State Accepted
Delegated to: David Miller
Headers show

Comments

Denis V. Lunev - Oct. 8, 2008, 11:51 a.m.
Removed.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 include/net/ipv6.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
David Stevens - Oct. 8, 2008, 5:37 p.m.
This is there to parallel the definitions for other stats
macros. I don't think it should be removed, since it's
part of the standard interface for incrementing counters.
If someone has a need to increment it without, say, _BH,
I wouldn't want them to have to come up with it from
scratch again...

It's cost is the two lines of code it takes, but you could
consider it "documentation" for any future users that
want that variant.

                                        +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2008, 6:15 p.m.
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed,  8 Oct 2008 15:51:58 +0400

> Removed.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 8, 2008, 6:23 p.m.
From: David Stevens <dlstevens@us.ibm.com>
Date: Wed, 8 Oct 2008 10:37:25 -0700

> This is there to parallel the definitions for other stats
> macros. I don't think it should be removed, since it's
> part of the standard interface for incrementing counters.
> If someone has a need to increment it without, say, _BH,
> I wouldn't want them to have to come up with it from
> scratch again...
> 
> It's cost is the two lines of code it takes, but you could
> consider it "documentation" for any future users that
> want that variant.

I disagree.

It's more work to change interfaces globally like these namespace
guys frequently have to, if we leave unused interfaces around.

The changelog history clearly contains the old macro so it can
be resurrected properly, and folks such as you or myself can
point this out if someone adds an improper reimplementation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/net/ipv6.h b/include/net/ipv6.h
index 4736d8f..01da23c 100644
--- a/include/net/ipv6.h
+++ b/include/net/ipv6.h
@@ -148,8 +148,6 @@  DECLARE_SNMP_STAT(struct icmpv6msg_mib, icmpv6msg_statistics);
 	_DEVINC(icmpv6msg, , idev, field +256); })
 #define ICMP6MSGOUT_INC_STATS_BH(net, idev, field) ({ (void)(net); \
 	_DEVINC(icmpv6msg, _BH, idev, field +256); })
-#define ICMP6MSGIN_INC_STATS(idev, field) \
-	 _DEVINC(icmpv6msg, , idev, field)
 #define ICMP6MSGIN_INC_STATS_BH(idev, field) \
 	_DEVINC(icmpv6msg, _BH, idev, field)