diff mbox

host-fakeroot archive not sourced any more?

Message ID CAHkwnC99ifVpDJPBnMD+4rsWcykfMf2U4KTrtZRYqpkRVUfy1w@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Fabio Porcedda March 12, 2014, 12:44 p.m. UTC 
On Wed, Mar 12, 2014 at 1:18 PM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> On Wed, Mar 12, 2014 at 12:56 PM, Thomas De Schampheleire
> <patrickdepinguin@gmail.com> wrote:
>> On Wed, Mar 12, 2014 at 11:15 AM, Vincent Stehlé
>> <vincent.stehle@freescale.com> wrote:
>>> Hi,
>>>
>>> FYI it seems buildroot will not source host-fakeroot archive correctly any
>>> more when told to 'make source', with some configurations.
>>>
>>> This behavior can be seen for example on recent commit
>>> 1ea6d850891bb4d936bcf1bddbf5432b819d5785, with the following commands:
>>>
>>>   $ rm -fr ..config.tmp .config .config.old output dl/*fakeroot*
>>>   $ make qemu_arm_vexpress_defconfig
>>>   $ make source
>>>
>>> In this case, fakeroot_1.18.2.orig.tar.bz2 is not fetched.
>>>
>>> After bisect, it seems this behavior started with commit 'a248775 Makefile:
>>> add support for top-level parallel make'.
>>>
>>> A quick fix for 1ea6d850891bb4d936bcf1bddbf5432b819d5785 is to revert, in
>>> that order:
>>>
>>>   cf53e15 Makefile: remove BASE_TARGETS variable
>>>   fbb3b86 Makefile: ensure system is built ...
>>>   d4c0c64 Makefile: fix target-finalize rule
>>>   a248775 Makefile: add support for top-level parallel make
>>>
>>> ...and fakeroot archive is downloaded again.
>>>
>>
>> Vincent: thanks a lot for the report and the analysis!
>>
>> Fabio: what is your suggestion here?
>
> I will look at it, thanks for reporting it.


Can you try this patch?

 # all the package names listed in the HOST_<PKG>_DEPENDENCIES for each

Regards

Comments

Vincent Stehlé March 12, 2014, 2:11 p.m. UTC | #1 
On 03/12/2014 01:44 PM, Fabio Porcedda wrote:
> -               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
> +               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
> $(TARGETS_ROOTFS))),\

Hi Fabio,

Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start 
to use it instead of the reverts and see how it goes.

Best regards,

V.
Fabio Porcedda March 12, 2014, 2:25 p.m. UTC | #2 
On Wed, Mar 12, 2014 at 3:11 PM, Vincent Stehlé
<vincent.stehle@freescale.com> wrote:
> On 03/12/2014 01:44 PM, Fabio Porcedda wrote:
>>
>> -               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
>> +               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
>> $(TARGETS_ROOTFS))),\
>
>
> Hi Fabio,
>
> Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to
> use it instead of the reverts and see how it goes.

Great!
Thanks for testing it and sorry for the trouble.
I will send tomorrow the patch to the mailing list, maybe an improved
version because i fear that i need to add TARGETS_ROOTFS in more
places.

Best regards
Fabio Porcedda March 13, 2014, 4:38 p.m. UTC | #3 
On Wed, Mar 12, 2014 at 3:25 PM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> On Wed, Mar 12, 2014 at 3:11 PM, Vincent Stehlé
> <vincent.stehle@freescale.com> wrote:
>> On 03/12/2014 01:44 PM, Fabio Porcedda wrote:
>>>
>>> -               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
>>> +               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
>>> $(TARGETS_ROOTFS))),\
>>
>>
>> Hi Fabio,
>>
>> Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to
>> use it instead of the reverts and see how it goes.
>
> Great!
> Thanks for testing it and sorry for the trouble.
> I will send tomorrow the patch to the mailing list, maybe an improved
> version because i fear that i need to add TARGETS_ROOTFS in more
> places.

Patch sent:
http://patchwork.ozlabs.org/patch/330004/

Regards
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 481f779..e8e41a4 100644
--- a/Makefile
+++ b/Makefile
@@ -418,7 +418,7 @@  TARGETS_DIRCLEAN := $(patsubst %,%-dirclean,$(TARGETS))
 # variable for each enabled target.
 # Notice: this only works for newstyle gentargets/autotargets packages
 TARGETS_HOST_DEPS = $(sort $(filter host-%,$(foreach dep,\
-               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\
+               $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS)
$(TARGETS_ROOTFS))),\
                $($(dep)))))
 # Host packages can in turn have their own dependencies. Likewise find