| Message ID | 87ppls774g.fsf_-_@xmission.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: ebiederm@xmission.com (Eric W. Biederman) Date: Tue, 11 Mar 2014 14:33:35 -0700 > bcm_enet_netpoll does not exist, and causing > bcm63xx_net to fail to build when NET_POLL_CONTROLLER > is defined. > > Remove the bogus .ndo_poll_controller = bcm_enet_netpoll > > Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Applied. This driver doesn't get a lot of build testing, and that's due to the platform BCM63XX kconfig option it depends upon. Probably it should be exposed more widely to perhaps a more broad dependency such as CONFIG_OF. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2014-03-13 12:26 GMT-07:00 David Miller <davem@davemloft.net>: > From: ebiederm@xmission.com (Eric W. Biederman) > Date: Tue, 11 Mar 2014 14:33:35 -0700 > >> bcm_enet_netpoll does not exist, and causing >> bcm63xx_net to fail to build when NET_POLL_CONTROLLER >> is defined. >> >> Remove the bogus .ndo_poll_controller = bcm_enet_netpoll >> >> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> > > Applied. > > This driver doesn't get a lot of build testing, and that's due to the > platform BCM63XX kconfig option it depends upon. Probably it should > be exposed more widely to perhaps a more broad dependency such as > CONFIG_OF. There is no OF-aware platform using that driver. Part of the reason why it does not get much build coverage is the large header dependencies provided by arch/mips/include/asm/mach-bcm63xx. I will work on improving that.
From: Florian Fainelli <f.fainelli@gmail.com> Date: Thu, 13 Mar 2014 12:42:22 -0700 > There is no OF-aware platform using that driver. Part of the reason > why it does not get much build coverage is the large header > dependencies provided by arch/mips/include/asm/mach-bcm63xx. I will > work on improving that. Thanks in advance. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index b9a5fb6400d3..a7d11f5565d6 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -1722,9 +1722,6 @@ static const struct net_device_ops bcm_enet_ops = { .ndo_set_rx_mode = bcm_enet_set_multicast_list, .ndo_do_ioctl = bcm_enet_ioctl, .ndo_change_mtu = bcm_enet_change_mtu, -#ifdef CONFIG_NET_POLL_CONTROLLER - .ndo_poll_controller = bcm_enet_netpoll, -#endif }; /*
bcm_enet_netpoll does not exist, and causing bcm63xx_net to fail to build when NET_POLL_CONTROLLER is defined. Remove the bogus .ndo_poll_controller = bcm_enet_netpoll Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)