Patchwork mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH

login
register
mail settings
Submitter Erico Nunes
Date March 11, 2014, 4:31 a.m.
Message ID <1394512286-31481-1-git-send-email-nunes.erico@gmail.com>
Download mbox | patch
Permalink /patch/328924/
State Accepted
Commit 148256fa0bb8e05a00db3f204b36e19e6312102c
Headers show

Comments

Erico Nunes - March 11, 2014, 4:31 a.m.
Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
doesn't match the exact name of the configuration option.
This warning showed up once to me when I was starting to set up BCH. After
checking my .config file, it took a moment before realizing it is
CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 drivers/mtd/nand/nand_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Lee Jones - March 11, 2014, 8:39 a.m.
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  drivers/mtd/nand/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9715a7b..5a93787 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
>  
>  	case NAND_ECC_SOFT_BCH:
>  		if (!mtd_nand_has_bch()) {
> -			pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
> +			pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
>  			BUG();
>  		}
>  		ecc->calculate = nand_bch_calculate_ecc;

Not sure if CONFIG options should be printed in the log at all, but
the correct option is better than an incorrect one. Seeing as
CONFIG_MTD_ECC_BCH doesn't actually exist:
  Acked-by: Lee Jones <lee.jones@linaro.org>
Erico Nunes - March 25, 2014, 10:28 p.m.
2014-03-11 1:31 GMT-03:00 Erico Nunes <nunes.erico@gmail.com>:
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  drivers/mtd/nand/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9715a7b..5a93787 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
>
>         case NAND_ECC_SOFT_BCH:
>                 if (!mtd_nand_has_bch()) {
> -                       pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
> +                       pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
>                         BUG();
>                 }
>                 ecc->calculate = nand_bch_calculate_ecc;
> --
> 1.9.0
>

Ping.
Brian Norris - March 26, 2014, 7:34 a.m.
On Tue, Mar 11, 2014 at 01:31:26AM -0300, Erico Nunes wrote:
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

Pushed to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 9715a7b..5a93787 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3825,7 +3825,7 @@  int nand_scan_tail(struct mtd_info *mtd)
 
 	case NAND_ECC_SOFT_BCH:
 		if (!mtd_nand_has_bch()) {
-			pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
+			pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
 			BUG();
 		}
 		ecc->calculate = nand_bch_calculate_ecc;