Patchwork don't call cpu_sychronize_state from reset handlers

login
register
mail settings
Submitter Glauber Costa
Date Sept. 2, 2009, 9:18 p.m.
Message ID <1251926323-16088-1-git-send-email-glommer@redhat.com>
Download mbox | patch
Permalink /patch/32847/
State Superseded
Headers show

Comments

Glauber Costa - Sept. 2, 2009, 9:18 p.m.
Doing this will make the vcpu ioctl be issued from the I/O thread, instead
of cpu thread. The correct behaviour is to call it from within the cpu thread,
as soon as we are ready to go.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 hw/apic.c |    2 --
 vl.c      |    7 ++++++-
 2 files changed, 6 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/apic.c b/hw/apic.c
index 2c414c1..9f1d25e 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -938,8 +938,6 @@  static void apic_reset(void *opaque)
     APICState *s = opaque;
     int bsp;
 
-    cpu_synchronize_state(s->cpu_env);
-
     bsp = cpu_is_bsp(s->cpu_env);
     s->apicbase = 0xfee00000 |
         (bsp ? MSR_IA32_APICBASE_BSP : 0) | MSR_IA32_APICBASE_ENABLE;
diff --git a/vl.c b/vl.c
index accd69e..ff6a597 100644
--- a/vl.c
+++ b/vl.c
@@ -3759,10 +3759,12 @@  static void *kvm_cpu_thread_fn(void *arg)
     while (!qemu_system_ready)
         qemu_cond_timedwait(&qemu_system_cond, &qemu_global_mutex, 100);
 
+    cpu_synchronize_state(env);
+
     while (1) {
+        qemu_wait_io_event(env);
         if (cpu_can_run(env))
             qemu_cpu_exec(env);
-        qemu_wait_io_event(env);
     }
 
     return NULL;
@@ -3787,6 +3789,9 @@  static void *tcg_cpu_thread_fn(void *arg)
     while (!qemu_system_ready)
         qemu_cond_timedwait(&qemu_system_cond, &qemu_global_mutex, 100);
 
+    for (env = first_cpu; env != NULL; env = env->next_cpu) {
+        cpu_synchronize_state(env);
+    }
     while (1) {
         tcg_cpu_exec();
         qemu_wait_io_event(cur_cpu);