Patchwork [wwwdocs] RFC - mention Cilk Plus in the GCC 4.9 release notes

login
register
mail settings
Submitter Tobias Burnus
Date March 8, 2014, 8:32 p.m.
Message ID <531B7E49.8060406@net-b.de>
Download mbox | patch
Permalink /patch/328245/
State New
Headers show

Comments

Tobias Burnus - March 8, 2014, 8:32 p.m.
Am 08.03.2014 21:13, schrieb Andi Kleen:
> Also it would be good to specify exactly what parts of Cilk are 
> supported currently. It's some what hard to figure out.

My understanding is that everything but cilk_for is supported.

> One trap I ran into (perhaps naively) is that I tried to use 
> cilk_spawn (as documented in some tutorials) instead of _Cilk_spawn

It should work with:
   #include <cilk.h>

However, the following file is not installed: libcilkrts/include/cilk/cilk.h
I think something like the following should work (untested).

Tobias
Iyer, Balaji V - March 8, 2014, 8:38 p.m.
> -----Original Message-----
> From: Tobias Burnus [mailto:burnus@net-b.de]
> Sent: Saturday, March 8, 2014 3:32 PM
> To: Andi Kleen; Iyer, Balaji V
> Cc: Gerald Pfeifer; gcc-patches; Jakub Jelinek
> Subject: Re: [wwwdocs] RFC - mention Cilk Plus in the GCC 4.9 release notes
> 
> Am 08.03.2014 21:13, schrieb Andi Kleen:
> > Also it would be good to specify exactly what parts of Cilk are
> > supported currently. It's some what hard to figure out.
> 
> My understanding is that everything but cilk_for is supported.

Yes you are correct.

> 
> > One trap I ran into (perhaps naively) is that I tried to use
> > cilk_spawn (as documented in some tutorials) instead of _Cilk_spawn
> 
> It should work with:
>    #include <cilk.h>
                          ^ should be cilk/cilk.h
> 

I responded more details in my previous email..

> However, the following file is not installed: libcilkrts/include/cilk/cilk.h I think
> something like the following should work (untested).
> 
> Tobias
> 
> --- a/libcilkrts/Makefile.am
> +++ b/libcilkrts/Makefile.am
> @@ -53,4 +53,5 @@ gcc_version := $(shell cat $(top_srcdir)/../gcc/BASE-VER)
>   # Target list.
>   toolexeclib_LTLIBRARIES = libcilkrts.la
> +nodist_libsubinclude_HEADERS = include/cilk/cilk.h
> 
>   libcilkrts_la_SOURCES =            \

Patch

--- a/libcilkrts/Makefile.am
+++ b/libcilkrts/Makefile.am
@@ -53,4 +53,5 @@  gcc_version := $(shell cat $(top_srcdir)/../gcc/BASE-VER)
  # Target list.
  toolexeclib_LTLIBRARIES = libcilkrts.la
+nodist_libsubinclude_HEADERS = include/cilk/cilk.h

  libcilkrts_la_SOURCES =            \