Patchwork [RFC,v2,06/11] tty: xuartps: Change driver name to 'cdns-uart'

login
register
mail settings
Submitter Soren Brinkmann
Date March 7, 2014, 7:13 p.m.
Message ID <1394219614-3197-7-git-send-email-soren.brinkmann@xilinx.com>
Download mbox | patch
Permalink /patch/328054/
State New
Headers show

Comments

Soren Brinkmann - March 7, 2014, 7:13 p.m.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
I'm not sure about this change. Is this acceptable or already too much?
I think the name is used for some sysfs entries.

	Sören
---
 drivers/tty/serial/xilinx_uartps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
One Thousand Gnomes - March 7, 2014, 9:29 p.m.
On Fri,  7 Mar 2014 11:13:29 -0800
Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:

> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> I'm not sure about this change. Is this acceptable or already too much?
> I think the name is used for some sysfs entries.

Its probably not a good idea. You might be ok depending whether anything
ever used the sysfs nodes.

Alan
Soren Brinkmann - March 7, 2014, 10:58 p.m.
On Fri, 2014-03-07 at 09:29PM +0000, One Thousand Gnomes wrote:
> On Fri,  7 Mar 2014 11:13:29 -0800
> Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> 
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > ---
> > I'm not sure about this change. Is this acceptable or already too much?
> > I think the name is used for some sysfs entries.
> 
> Its probably not a good idea. You might be ok depending whether anything
> ever used the sysfs nodes.

Okay, I'll drop this.

	Thanks,
	Sören

Patch

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index b4a2a68b5e0e..3be1da41c2a8 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -31,7 +31,7 @@ 
 #include <linux/module.h>
 
 #define XUARTPS_TTY_NAME	"ttyPS"
-#define XUARTPS_NAME		"xuartps"
+#define XUARTPS_NAME		"cdns-uart"
 #define XUARTPS_MAJOR		0	/* use dynamic node allocation */
 #define XUARTPS_MINOR		0	/* works best with devtmpfs */
 #define XUARTPS_NR_PORTS	2