Patchwork mtd: Kconfig: give the CFI command set version in prompt and help

login
register
mail settings
Submitter Philippe De Muyter
Date March 7, 2014, 3:04 p.m.
Message ID <1394204641-23453-1-git-send-email-phdm@macqel.be>
Download mbox | patch
Permalink /patch/328007/
State Accepted
Commit 5a4c4c5eb1939fff1a95d0812d01731cdda3694a
Headers show

Comments

Philippe De Muyter - March 7, 2014, 3:04 p.m.
Enhances the help for the CFI command set choices.

Signed-off-by: Philippe De Muyter <phdm@macqel.be>
---
 drivers/mtd/chips/Kconfig |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
Lee Jones - March 11, 2014, 10:27 a.m.
> Enhances the help for the CFI command set choices.
> 
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> ---
>  drivers/mtd/chips/Kconfig |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
> index e4696b3..9f02c28 100644
> --- a/drivers/mtd/chips/Kconfig
> +++ b/drivers/mtd/chips/Kconfig
> @@ -169,33 +169,33 @@ config MTD_OTP
>  	  in the programming of OTP bits will waste them.
>  
>  config MTD_CFI_INTELEXT
> -	tristate "Support for Intel/Sharp flash chips"
> +	tristate "Support for CFI command set 0001 (Intel/Sharp chips)"

tristate "Support for Intel/Sharp flash chips (CFI Command Set 0001)"

>  	depends on MTD_GEN_PROBE
>  	select MTD_CFI_UTIL
>  	help
>  	  The Common Flash Interface defines a number of different command
>  	  sets which a CFI-compliant chip may claim to implement. This code
> -	  provides support for one of those command sets, used on Intel
> -	  StrataFlash and other parts.
> +	  provides support for command set 0001, used on Intel StrataFlash
> +	  and other parts.
>  
>  config MTD_CFI_AMDSTD
> -	tristate "Support for AMD/Fujitsu/Spansion flash chips"
> +	tristate "Support for CFI command set 0002 (AMD/Fujitsu/Spansion chips)"

tristate "Support for AMD/Fujitsu/Spansion flash chips (CFI Command Set 0002)"

Etc ... read better for me.

[...]
Philippe De Muyter - March 11, 2014, 11:53 a.m.
On Tue, Mar 11, 2014 at 10:27:38AM +0000, Lee Jones wrote:
> > Enhances the help for the CFI command set choices.
> > 
> > Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> > ---
> >  drivers/mtd/chips/Kconfig |   16 ++++++++--------
> >  1 files changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
> > index e4696b3..9f02c28 100644
> > --- a/drivers/mtd/chips/Kconfig
> > +++ b/drivers/mtd/chips/Kconfig
> > @@ -169,33 +169,33 @@ config MTD_OTP
> >  	  in the programming of OTP bits will waste them.
> >  
> >  config MTD_CFI_INTELEXT
> > -	tristate "Support for Intel/Sharp flash chips"
> > +	tristate "Support for CFI command set 0001 (Intel/Sharp chips)"
> 
> tristate "Support for Intel/Sharp flash chips (CFI Command Set 0001)"
> 
> >  	depends on MTD_GEN_PROBE
> >  	select MTD_CFI_UTIL
> >  	help
> >  	  The Common Flash Interface defines a number of different command
> >  	  sets which a CFI-compliant chip may claim to implement. This code
> > -	  provides support for one of those command sets, used on Intel
> > -	  StrataFlash and other parts.
> > +	  provides support for command set 0001, used on Intel StrataFlash
> > +	  and other parts.
> >  
> >  config MTD_CFI_AMDSTD
> > -	tristate "Support for AMD/Fujitsu/Spansion flash chips"
> > +	tristate "Support for CFI command set 0002 (AMD/Fujitsu/Spansion chips)"
> 
> tristate "Support for AMD/Fujitsu/Spansion flash chips (CFI Command Set 0002)"
> 
> Etc ... read better for me.

What's important here is the command set version, not the names of some
old flash chips producers.  Some have stopped producing flash chips
or have sold or renamed their flash chips divisions.

And on a 80 columns screen, the command set version would fall out of the
screen in menuconfig.

Philippe
Brian Norris - May 21, 2014, 12:41 a.m.
On Fri, Mar 07, 2014 at 04:04:01PM +0100, Philippe De Muyter wrote:
> Enhances the help for the CFI command set choices.
> 
> Signed-off-by: Philippe De Muyter <phdm@macqel.be>

Pushed to l2-mtd.git. Thanks!

Brian

Patch

diff --git a/drivers/mtd/chips/Kconfig b/drivers/mtd/chips/Kconfig
index e4696b3..9f02c28 100644
--- a/drivers/mtd/chips/Kconfig
+++ b/drivers/mtd/chips/Kconfig
@@ -169,33 +169,33 @@  config MTD_OTP
 	  in the programming of OTP bits will waste them.
 
 config MTD_CFI_INTELEXT
-	tristate "Support for Intel/Sharp flash chips"
+	tristate "Support for CFI command set 0001 (Intel/Sharp chips)"
 	depends on MTD_GEN_PROBE
 	select MTD_CFI_UTIL
 	help
 	  The Common Flash Interface defines a number of different command
 	  sets which a CFI-compliant chip may claim to implement. This code
-	  provides support for one of those command sets, used on Intel
-	  StrataFlash and other parts.
+	  provides support for command set 0001, used on Intel StrataFlash
+	  and other parts.
 
 config MTD_CFI_AMDSTD
-	tristate "Support for AMD/Fujitsu/Spansion flash chips"
+	tristate "Support for CFI command set 0002 (AMD/Fujitsu/Spansion chips)"
 	depends on MTD_GEN_PROBE
 	select MTD_CFI_UTIL
 	help
 	  The Common Flash Interface defines a number of different command
 	  sets which a CFI-compliant chip may claim to implement. This code
-	  provides support for one of those command sets, used on chips
-	  including the AMD Am29LV320.
+	  provides support for command set 0002, used on chips including
+	  the AMD Am29LV320.
 
 config MTD_CFI_STAA
-	tristate "Support for ST (Advanced Architecture) flash chips"
+	tristate "Support for CFI command set 0020 (ST (Advanced Architecture) chips)"
 	depends on MTD_GEN_PROBE
 	select MTD_CFI_UTIL
 	help
 	  The Common Flash Interface defines a number of different command
 	  sets which a CFI-compliant chip may claim to implement. This code
-	  provides support for one of those command sets.
+	  provides support for command set 0020.
 
 config MTD_CFI_UTIL
 	tristate