diff mbox

[core/doc] doc/Makefile: add pdf output too

Message ID 1394185927-24177-1-git-send-email-jabk@prevas.dk
State Rejected
Delegated to: Esben Haabendal
Headers show

Commit Message

Jacob Kjaergaard March 7, 2014, 9:52 a.m. UTC
From: Jacob Kjaergaard <jacob.kjaergaard@prevas.dk>

---
 classes/package-qa.oeclass |    2 +-
 doc/Makefile               |    5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

Comments

Esben Haabendal May 13, 2014, 11:31 a.m. UTC | #1
<jabk@prevas.dk> writes:

> From: Jacob Kjaergaard <jacob.kjaergaard@prevas.dk>
>
> ---
>  classes/package-qa.oeclass |    2 +-
>  doc/Makefile               |    5 ++++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/classes/package-qa.oeclass b/classes/package-qa.oeclass
> index 1a7228f..883e24e 100644
> --- a/classes/package-qa.oeclass
> +++ b/classes/package-qa.oeclass
> @@ -184,7 +184,7 @@ addtask packageqa after package
>  
>  # FIXME: improve gcc packaging, so that readelf can be obtained
>  # without pulling in entire toolchain
> -inherit c
> +#inherit c

I guess you did intend to include this change in this commit.  Please
repost as seperate patch if you want to resolve this "FIXME".

>  
>  do_packageqa[dirs] = "${PKGD}"
>  
> diff --git a/doc/Makefile b/doc/Makefile
> index 83bd6a6..bca2182 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -1,5 +1,5 @@
>  .PHONY: all
> -all: autodoc manual.html
> +all: autodoc manual.html manual.pdf

I think we should keep focus on the HTML output.  Anyone is of-course
free to create PDF, but the official OE-lite/core Reference Manual will
be kept in HTML.

>  
>  .PHONY: clean
>  clean:
> @@ -16,3 +16,6 @@ manual.html: $(wildcard *.txt)
>  upload: all
>  	rsync -av --delete manual.html images \
>  		oe-lite.org:/srv/http/doc/core/master/
> +
> +manual.pdf: $(wildcard *.txt)
> +	a2x -a docinfo -d book -f pdf --fop manual.txt

Thus requiring both a2x and asciidoc commands on host.

Do you have any special reason for needing this in upstream OE-lite/core
?

/Esben
Esben Haabendal May 13, 2014, 12:34 p.m. UTC | #2
Jacob Barsøe Kjærgaard <jacob.kjaergaard@prevas.dk> writes:

>> Do you have any special reason for needing this in upstream OE-lite/core
>> ?
> Nope. Except if nice-to-have is a special reason :)

Hehe, I was aiming for something a bit more special :)

/Esben
diff mbox

Patch

diff --git a/classes/package-qa.oeclass b/classes/package-qa.oeclass
index 1a7228f..883e24e 100644
--- a/classes/package-qa.oeclass
+++ b/classes/package-qa.oeclass
@@ -184,7 +184,7 @@  addtask packageqa after package
 
 # FIXME: improve gcc packaging, so that readelf can be obtained
 # without pulling in entire toolchain
-inherit c
+#inherit c
 
 do_packageqa[dirs] = "${PKGD}"
 
diff --git a/doc/Makefile b/doc/Makefile
index 83bd6a6..bca2182 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -1,5 +1,5 @@ 
 .PHONY: all
-all: autodoc manual.html
+all: autodoc manual.html manual.pdf
 
 .PHONY: clean
 clean:
@@ -16,3 +16,6 @@  manual.html: $(wildcard *.txt)
 upload: all
 	rsync -av --delete manual.html images \
 		oe-lite.org:/srv/http/doc/core/master/
+
+manual.pdf: $(wildcard *.txt)
+	a2x -a docinfo -d book -f pdf --fop manual.txt