| Message ID | 1394116729-28811-4-git-send-email-rogerq@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Felipe, On Thursday 06 March 2014 08:08 PM, Roger Quadros wrote: > The dra7-usb2 and am437-usb2 bindings have not yet been used. > Change them to be more elegant. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 4 ++-- Here too.. Acked-by: Kishon Vijay Abraham I <kishon@ti.com> Regards Kishon > drivers/phy/phy-omap-control.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 5c5b1b0..28e674b 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -9,9 +9,9 @@ Required properties: > e.g. USB2_PHY on OMAP5. > "ti,control-phy-pipe3" - if it has DPLL and individual Rx & Tx power control > e.g. USB3 PHY and SATA PHY on OMAP5. > - "ti,control-phy-dra7usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-dra7-usb2" - if it has power down register like USB2 PHY on > DRA7 platform. > - "ti,control-phy-am437usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-am437-usb2" - if it has power down register like USB2 PHY on > AM437 platform. > - reg : Address and length of the register set for the device. It contains > the address of "otghs_control" for control-phy-otghs or "power" register > diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c > index 17fc200..a7e2d7f 100644 > --- a/drivers/phy/phy-omap-control.c > +++ b/drivers/phy/phy-omap-control.c > @@ -228,11 +228,11 @@ static const struct of_device_id omap_control_phy_id_table[] = { > .data = &pipe3_data, > }, > { > - .compatible = "ti,control-phy-dra7usb2", > + .compatible = "ti,control-phy-dra7-usb2", > .data = &dra7usb2_data, > }, > { > - .compatible = "ti,control-phy-am437usb2", > + .compatible = "ti,control-phy-am437-usb2", > .data = &am437usb2_data, > }, > {}, > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 06, 2014 at 04:38:39PM +0200, Roger Quadros wrote: > The dra7-usb2 and am437-usb2 bindings have not yet been used. > Change them to be more elegant. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 4 ++-- > drivers/phy/phy-omap-control.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 5c5b1b0..28e674b 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -9,9 +9,9 @@ Required properties: > e.g. USB2_PHY on OMAP5. > "ti,control-phy-pipe3" - if it has DPLL and individual Rx & Tx power control > e.g. USB3 PHY and SATA PHY on OMAP5. > - "ti,control-phy-dra7usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-dra7-usb2" - if it has power down register like USB2 PHY on > DRA7 platform. > - "ti,control-phy-am437usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-am437-usb2" - if it has power down register like USB2 PHY on > AM437 platform. > - reg : Address and length of the register set for the device. It contains > the address of "otghs_control" for control-phy-otghs or "power" register I can take the Documentation part (which I've just done) but... > diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c > index 17fc200..a7e2d7f 100644 > --- a/drivers/phy/phy-omap-control.c > +++ b/drivers/phy/phy-omap-control.c > @@ -228,11 +228,11 @@ static const struct of_device_id omap_control_phy_id_table[] = { > .data = &pipe3_data, > }, > { > - .compatible = "ti,control-phy-dra7usb2", > + .compatible = "ti,control-phy-dra7-usb2", > .data = &dra7usb2_data, > }, > { > - .compatible = "ti,control-phy-am437usb2", > + .compatible = "ti,control-phy-am437-usb2", > .data = &am437usb2_data, > }, > {}, I don't have this file in my tree ;-)
On Friday 07 March 2014 01:55 PM, Kishon Vijay Abraham I wrote: > From: Felipe Balbi <balbi@ti.com> > > From: Roger Quadros <rogerq@ti.com> There seems to be some problem with this patch. Pls ignore this. Thanks Kishon > > The dra7-usb2 and am437-usb2 bindings have not yet been used. > Change them to be more elegant. > > Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > Changes from v3: > * changed the compatible name to 'ti,control-phy-usb2-dra7' and > 'ti,control-phy-usb2-am437' > > Documentation/devicetree/bindings/phy/ti-phy.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 41dc132..8694aae 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -9,9 +9,9 @@ Required properties: > e.g. USB2_PHY on OMAP5. > "ti,control-phy-pipe3" - if it has DPLL and individual Rx & Tx power control > e.g. USB3 PHY and SATA PHY on OMAP5. > - "ti,control-phy-dra7usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-usb2-dra7" - if it has power down register like USB2 PHY on > DRA7 platform. > - "ti,control-phy-am437usb2" - if it has power down register like USB2 PHY on > + "ti,control-phy-usb2-am437" - if it has power down register like USB2 PHY on > AM437 platform. > - reg : Address and length of the register set for the device. It contains > the address of "otghs_control" for control-phy-otghs or "power" register > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt index 5c5b1b0..28e674b 100644 --- a/Documentation/devicetree/bindings/phy/ti-phy.txt +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt @@ -9,9 +9,9 @@ Required properties: e.g. USB2_PHY on OMAP5. "ti,control-phy-pipe3" - if it has DPLL and individual Rx & Tx power control e.g. USB3 PHY and SATA PHY on OMAP5. - "ti,control-phy-dra7usb2" - if it has power down register like USB2 PHY on + "ti,control-phy-dra7-usb2" - if it has power down register like USB2 PHY on DRA7 platform. - "ti,control-phy-am437usb2" - if it has power down register like USB2 PHY on + "ti,control-phy-am437-usb2" - if it has power down register like USB2 PHY on AM437 platform. - reg : Address and length of the register set for the device. It contains the address of "otghs_control" for control-phy-otghs or "power" register diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c index 17fc200..a7e2d7f 100644 --- a/drivers/phy/phy-omap-control.c +++ b/drivers/phy/phy-omap-control.c @@ -228,11 +228,11 @@ static const struct of_device_id omap_control_phy_id_table[] = { .data = &pipe3_data, }, { - .compatible = "ti,control-phy-dra7usb2", + .compatible = "ti,control-phy-dra7-usb2", .data = &dra7usb2_data, }, { - .compatible = "ti,control-phy-am437usb2", + .compatible = "ti,control-phy-am437-usb2", .data = &am437usb2_data, }, {},
The dra7-usb2 and am437-usb2 bindings have not yet been used. Change them to be more elegant. Signed-off-by: Roger Quadros <rogerq@ti.com> --- Documentation/devicetree/bindings/phy/ti-phy.txt | 4 ++-- drivers/phy/phy-omap-control.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)