From patchwork Wed Oct 8 07:44:33 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Oberritter X-Patchwork-Id: 3274 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id B124FDDEDF for ; Wed, 8 Oct 2008 18:54:46 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753870AbYJHHym (ORCPT ); Wed, 8 Oct 2008 03:54:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753809AbYJHHym (ORCPT ); Wed, 8 Oct 2008 03:54:42 -0400 Received: from ffm.saftware.de ([83.141.3.46]:40905 "EHLO ffm.saftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753750AbYJHHyl (ORCPT ); Wed, 8 Oct 2008 03:54:41 -0400 X-Greylist: delayed 606 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 Oct 2008 03:54:41 EDT Received: from localhost (localhost [127.0.0.1]) by ffm.saftware.de (Postfix) with ESMTP id 962D9E6DB6; Wed, 8 Oct 2008 09:44:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ffm.saftware.de Received: from ffm.saftware.de ([83.141.3.46]) by localhost (pinky.saftware.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id VnaaV6CtXPG5; Wed, 8 Oct 2008 09:44:32 +0200 (CEST) Received: from [172.22.22.60] (unknown [92.50.105.71]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ffm.saftware.de (Postfix) with ESMTPSA id 0D852E6DA6; Wed, 8 Oct 2008 09:44:32 +0200 (CEST) Message-ID: <48EC64E1.5070806@linuxtv.org> Date: Wed, 08 Oct 2008 09:44:33 +0200 From: Andreas Oberritter User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Jeff Garzik CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] 8139too: move wmb before TX DMA start X-Enigmail-Version: 0.95.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andreas Oberritter The write barrier should be used before starting a DMA transfer. This fixes a problem, where almost all packets received on another machine had garbled content. Tested with an RTL8100C on a MIPS machine. Signed-off-by: Andreas Oberritter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c index 53bd903..44344af 100644 --- a/drivers/net/8139too.c +++ b/drivers/net/8139too.c @@ -1716,13 +1716,13 @@ static int rtl8139_start_xmit (struct sk_buff *skb, struct net_device *dev) } spin_lock_irqsave(&tp->lock, flags); + wmb(); RTL_W32_F (TxStatus0 + (entry * sizeof (u32)), tp->tx_flag | max(len, (unsigned int)ETH_ZLEN)); dev->trans_start = jiffies; tp->cur_tx++; - wmb(); if ((tp->cur_tx - NUM_TX_DESC) == tp->dirty_tx) netif_stop_queue (dev);