| Message ID | 1394098949-31981-5-git-send-email-fabio.porcedda@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On 06/03/14 10:42, Fabio Porcedda wrote: > The "dirs" dependency is redundant because now the "generic-package" > infrastructure add automatically the "dirs" dependency so just remove > the redundant references. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> There are also redundant dependencies on dirs in Makefile and in package/uclibc/uclibc.mk - that can be done in a separate patch, but if you get around to fixing the other places before this one gets committed please do include it. Regards, Arnout > --- > linux/linux.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux/linux.mk b/linux/linux.mk > index 3d52e69..e270705 100644 > --- a/linux/linux.mk > +++ b/linux/linux.mk > @@ -302,12 +302,12 @@ include $(sort $(wildcard linux/linux-ext-*.mk)) > $(eval $(generic-package)) > > ifeq ($(BR2_LINUX_KERNEL),y) > -linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs linux-configure > +linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: linux-configure > $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \ > $(subst linux-,,$(subst linux26-,,$@)) > rm -f $(LINUX_DIR)/.stamp_{built,target_installed,images_installed} > > -linux-savedefconfig linux26-savedefconfig: dirs linux-configure > +linux-savedefconfig linux26-savedefconfig: linux-configure > $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \ > $(subst linux-,,$(subst linux26-,,$@)) > >
On Thu, Mar 6, 2014 at 6:37 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 06/03/14 10:42, Fabio Porcedda wrote: >> The "dirs" dependency is redundant because now the "generic-package" >> infrastructure add automatically the "dirs" dependency so just remove >> the redundant references. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > > > There are also redundant dependencies on dirs in Makefile and in > package/uclibc/uclibc.mk - that can be done in a separate patch, but if > you get around to fixing the other places before this one gets committed > please do include it. Hi Arnout, thanks for reviewing. I will send a patch to remove the dirs dependency from the other files. Regards Fabio Porcedda
diff --git a/linux/linux.mk b/linux/linux.mk index 3d52e69..e270705 100644 --- a/linux/linux.mk +++ b/linux/linux.mk @@ -302,12 +302,12 @@ include $(sort $(wildcard linux/linux-ext-*.mk)) $(eval $(generic-package)) ifeq ($(BR2_LINUX_KERNEL),y) -linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs linux-configure +linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: linux-configure $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \ $(subst linux-,,$(subst linux26-,,$@)) rm -f $(LINUX_DIR)/.stamp_{built,target_installed,images_installed} -linux-savedefconfig linux26-savedefconfig: dirs linux-configure +linux-savedefconfig linux26-savedefconfig: linux-configure $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \ $(subst linux-,,$(subst linux26-,,$@))
The "dirs" dependency is redundant because now the "generic-package" infrastructure add automatically the "dirs" dependency so just remove the redundant references. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- linux/linux.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)