Patchwork [5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register

login
register
mail settings
Submitter Josh Cartwright
Date March 5, 2014, 7:29 p.m.
Message ID <1394047776-13827-6-git-send-email-joshc@codeaurora.org>
Download mbox | patch
Permalink /patch/327134/
State New
Headers show

Comments

Josh Cartwright - March 5, 2014, 7:29 p.m.
Setup wakeup capability before rtc_register to ensure the rtc class core
properly sets up our 'wakealarm' sysfs attribute.

Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
---
 drivers/rtc/rtc-pm8xxx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Stephen Boyd - March 5, 2014, 8:59 p.m.
On 03/05/14 11:29, Josh Cartwright wrote:
> Setup wakeup capability before rtc_register to ensure the rtc class core
> properly sets up our 'wakealarm' sysfs attribute.
>
> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

Patch

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index cb5576f..761be65 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -422,6 +422,8 @@  static int pm8xxx_rtc_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, rtc_dd);
 
+	device_init_wakeup(&pdev->dev, 1);
+
 	/* Register the RTC device */
 	rtc_dd->rtc = devm_rtc_device_register(&pdev->dev, "pm8xxx_rtc",
 					       &pm8xxx_rtc_ops, THIS_MODULE);
@@ -441,8 +443,6 @@  static int pm8xxx_rtc_probe(struct platform_device *pdev)
 		return rc;
 	}
 
-	device_init_wakeup(&pdev->dev, 1);
-
 	dev_dbg(&pdev->dev, "Probe success !!\n");
 
 	return 0;