diff mbox

[U-Boot] pinmux:exynos:uart:fix: Add default statement to remove warnings (gcc-4.8.2)

Message ID 1394035457-3740-1-git-send-email-l.majewski@samsung.com
State Superseded
Delegated to: Minkyu Kang
Headers show

Commit Message

Łukasz Majewski March 5, 2014, 4:04 p.m. UTC 
For Exynos' pinmux UART implementation there was a possibility to run
for() statement with uninitialized bank, start and count values.

Those warnings appear when following toolchain is used (gcc-4.8.2-glibc-2.18-binutils-2.24):

warning: 'count' may be used uninitialized in this function [-Wmaybe-uninitialized]

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
 arch/arm/cpu/armv7/exynos/pinmux.c |    9 +++++++++
 1 file changed, 9 insertions(+)
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c
index 645c497..494f608 100644
--- a/arch/arm/cpu/armv7/exynos/pinmux.c
+++ b/arch/arm/cpu/armv7/exynos/pinmux.c
@@ -39,6 +39,9 @@  static void exynos5_uart_config(int peripheral)
 		start = 4;
 		count = 2;
 		break;
+	default:
+		error("UART device %d not implemented\n", peripheral);
+		return;
 	}
 	for (i = start; i < start + count; i++) {
 		s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);
@@ -74,6 +77,9 @@  static void exynos5420_uart_config(int peripheral)
 		start = 4;
 		count = 2;
 		break;
+	default:
+		error("UART device %d not implemented\n", peripheral);
+		return;
 	}
 
 	for (i = start; i < start + count; i++) {
@@ -683,6 +689,9 @@  static void exynos4_uart_config(int peripheral)
 		start = 4;
 		count = 2;
 		break;
+	default:
+		error("UART device %d not implemented\n", peripheral);
+		return;
 	}
 	for (i = start; i < start + count; i++) {
 		s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE);