Patchwork drivers: rtc: rtc-s3c: remove NO_IRQ macro

login
register
mail settings
Submitter Pankaj Dubey
Date March 5, 2014, 11:12 a.m.
Message ID <1394017975-4963-1-git-send-email-pankaj.dubey@samsung.com>
Download mbox | patch
Permalink /patch/326683/
State New
Headers show

Comments

Pankaj Dubey - March 5, 2014, 11:12 a.m.
NO_IRQ may be defined as '(unsigned int) -1' in some architectures
(arm, sh ...), and either may not be defined in some architectures
(arm64) which can enable RTC_DRV_S3C.
Also since platform_get_irq returns err-code in case of any error,
we do not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 drivers/rtc/rtc-s3c.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Pankaj Dubey - March 17, 2014, 1:21 a.m.
On 03/05/2014 08:12 PM, Pankaj Dubey wrote:
> NO_IRQ may be defined as '(unsigned int) -1' in some architectures
> (arm, sh ...), and either may not be defined in some architectures
> (arm64) which can enable RTC_DRV_S3C.
> Also since platform_get_irq returns err-code in case of any error,
> we do not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>   drivers/rtc/rtc-s3c.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 7afd373..cf2ebdd 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -48,8 +48,8 @@ struct s3c_rtc_drv_data {
>   
>   static struct clk *rtc_clk;
>   static void __iomem *s3c_rtc_base;
> -static int s3c_rtc_alarmno = NO_IRQ;
> -static int s3c_rtc_tickno  = NO_IRQ;
> +static int s3c_rtc_alarmno;
> +static int s3c_rtc_tickno;
>   static enum s3c_cpu_type s3c_rtc_cpu_type;
>   
>   static DEFINE_SPINLOCK(s3c_rtc_pie_lock);

Gentle Ping.

Patch

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 7afd373..cf2ebdd 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -48,8 +48,8 @@  struct s3c_rtc_drv_data {
 
 static struct clk *rtc_clk;
 static void __iomem *s3c_rtc_base;
-static int s3c_rtc_alarmno = NO_IRQ;
-static int s3c_rtc_tickno  = NO_IRQ;
+static int s3c_rtc_alarmno;
+static int s3c_rtc_tickno;
 static enum s3c_cpu_type s3c_rtc_cpu_type;
 
 static DEFINE_SPINLOCK(s3c_rtc_pie_lock);