diff mbox

[net-next] net/mlx4_en: mlx4_en_verify_params() can be static

Message ID 1394013443-17153-1-git-send-email-amirv@mellanox.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Amir Vadai March 5, 2014, 9:57 a.m. UTC 
From: Fengguang Wu <fengguang.wu@intel.com>

Fix static error introduced by commit:
b97b33a3df0439401f80f041eda507d4fffa0dbf [645/653] net/mlx4_en: Verify
mlx4_en module parameters

sparse warnings:
drivers/net/ethernet/mellanox/mlx4/en_main.c:335:6: sparse: symbol
'mlx4_en_verify_params' was not declared. Should it be static?

CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Eugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller March 6, 2014, 9:54 p.m. UTC | #1 
From: Amir Vadai <amirv@mellanox.com>
Date: Wed,  5 Mar 2014 11:57:23 +0200

> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> Fix static error introduced by commit:
> b97b33a3df0439401f80f041eda507d4fffa0dbf [645/653] net/mlx4_en: Verify
> mlx4_en module parameters
> 
> sparse warnings:
> drivers/net/ethernet/mellanox/mlx4/en_main.c:335:6: sparse: symbol
> 'mlx4_en_verify_params' was not declared. Should it be static?
> 
> CC: netdev@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Eugenia Emantayev <eugenia@mellanox.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_main.c b/drivers/net/ethernet/mellanox/mlx4/en_main.c
index 3454437..0c59d4f 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_main.c
@@ -332,7 +332,7 @@  static struct mlx4_interface mlx4_en_interface = {
 	.protocol	= MLX4_PROT_ETH,
 };
 
-void mlx4_en_verify_params(void)
+static void mlx4_en_verify_params(void)
 {
 	if (pfctx > MAX_PFC_TX) {
 		pr_warn("mlx4_en: WARNING: illegal module parameter pfctx 0x%x - should be in range 0-0x%x, will be changed to default (0)\n",