| Message ID | 1393948204-11555-6-git-send-email-Liviu.Dudau@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello, On Tue, Mar 4, 2014 at 7:50 AM, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > pci_alloc_child_bus() uses the newly allocated child bus to figure > out the domain number that is going to use for setting the device > name. A better option is to use the parent bus domain number. > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 26237a0..a12cda5 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -677,7 +677,7 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, > * now as the parent is not properly set up yet. > */ > child->dev.class = &pcibus_class; > - dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(child), busnr); > + dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(parent), busnr); > > /* > * Set up the primary, secondary and subordinate > -- > 1.9.0 > This patch is not required after the fix in pci_domain_nr for arm64. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 05, 2014 at 01:49:13AM +0000, Tanmay Inamdar wrote: > Hello, > > On Tue, Mar 4, 2014 at 7:50 AM, Liviu Dudau <Liviu.Dudau@arm.com> wrote: > > pci_alloc_child_bus() uses the newly allocated child bus to figure > > out the domain number that is going to use for setting the device > > name. A better option is to use the parent bus domain number. > > > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > > index 26237a0..a12cda5 100644 > > --- a/drivers/pci/probe.c > > +++ b/drivers/pci/probe.c > > @@ -677,7 +677,7 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, > > * now as the parent is not properly set up yet. > > */ > > child->dev.class = &pcibus_class; > > - dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(child), busnr); > > + dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(parent), busnr); > > > > /* > > * Set up the primary, secondary and subordinate > > -- > > 1.9.0 > > > > This patch is not required after the fix in pci_domain_nr for arm64. > True. Thanks for testing this! Liviu
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 26237a0..a12cda5 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -677,7 +677,7 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, * now as the parent is not properly set up yet. */ child->dev.class = &pcibus_class; - dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(child), busnr); + dev_set_name(&child->dev, "%04x:%02x", pci_domain_nr(parent), busnr); /* * Set up the primary, secondary and subordinate
pci_alloc_child_bus() uses the newly allocated child bus to figure out the domain number that is going to use for setting the device name. A better option is to use the parent bus domain number. Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>