diff mbox

[1/2] python-libconfig: new package

Message ID E1CF8EFE2042404B87DE2B6D662128020ED58B96@KUUMEX10.barco.com
State Superseded
Headers show

Commit Message

Johan Derycke March 4, 2014, 8:32 a.m. UTC 
Python bindings to the C++ library libconfig
https://github.com/cnangel/python-libconfig

Signed-off-by: Johan Derycke <johan.derycke@barco.com>
---
 package/python-libconfig/Config.in           |    9 +++++++++
 package/python-libconfig/python-libconfig.mk |   21 +++++++++++++++++++++
 2 files changed, 30 insertions(+)
 create mode 100644 package/python-libconfig/Config.in
 create mode 100644 package/python-libconfig/python-libconfig.mk

--
1.7.10.4

Best regards,
Johan Derycke





This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>

Comments

Baruch Siach March 4, 2014, 8:47 a.m. UTC | #1 
On Tue, Mar 04, 2014 at 08:32:47AM +0000, Derycke, Johan wrote:
> Python bindings to the C++ library libconfig
> https://github.com/cnangel/python-libconfig
> 
> Signed-off-by: Johan Derycke <johan.derycke@barco.com>
> ---
>  package/python-libconfig/Config.in           |    9 +++++++++
>  package/python-libconfig/python-libconfig.mk |   21 +++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 package/python-libconfig/Config.in
>  create mode 100644 package/python-libconfig/python-libconfig.mk
> 
> diff --git a/package/python-libconfig/Config.in b/package/python-libconfig/Config.in
> new file mode 100644
> index 0000000..7e4f317
> --- /dev/null
> +++ b/package/python-libconfig/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_LIBCONFIG
> +       bool "python-libconfig"
> +       depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> +  select BR2_PACKAGE_BOOST_PYTHON
> +       select BR2_PACKAGE_LIBCONFIG
> +       help
> +           Python bindings to the C++ library libconfig

Please fix indentation. See section 7.1.1 of the manual 
(http://buildroot.net/downloads/manual/manual.html).

> +
> +          https://github.com/cnangel/python-libconfig
> diff --git a/package/python-libconfig/python-libconfig.mk b/package/python-libconfig/python-libconfig.mk
> new file mode 100644
> index 0000000..8d597ef
> --- /dev/null
> +++ b/package/python-libconfig/python-libconfig.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# python-libconfig
> +#
> +################################################################################
> +
> +PYTHON_LIBCONFIG_VERSION = b271c3d9dac938ad5cd29b67bd08cc5536a5a391
> +PYTHON_LIBCONFIG_SITE = https://github.com/cnangel/python-libconfig/
> +PYTHON_LIBCONFIG_SITE_METHOD = git

Please use the github helper. See section 7.2.11 of the manual under "How to 
add a package from github".

> +
> +PYTHON_LIBCONFIG_LICENSE = BSD
> +PYTHON_LIBCONFIG_LICENSE_FILES = README
> +
> +PYTHON_LIBCONFIG_SETUP_TYPE = setuptools
> +
> +PYTHON_LIBCONFIG_DEPENDENCIES = libconfig boost
> +
> +$(eval $(python-package))
> +
> +
> +

Unneeded blank lines.

baruch
Arnout Vandecappelle March 5, 2014, 5:10 p.m. UTC | #2 
On 04/03/14 09:32, Derycke, Johan wrote:
> Python bindings to the C++ library libconfig
> https://github.com/cnangel/python-libconfig
> 
> Signed-off-by: Johan Derycke <johan.derycke@barco.com>
> ---
>  package/python-libconfig/Config.in           |    9 +++++++++
>  package/python-libconfig/python-libconfig.mk |   21 +++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 package/python-libconfig/Config.in
>  create mode 100644 package/python-libconfig/python-libconfig.mk
> 
> diff --git a/package/python-libconfig/Config.in b/package/python-libconfig/Config.in
> new file mode 100644
> index 0000000..7e4f317
> --- /dev/null
> +++ b/package/python-libconfig/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_LIBCONFIG
> +       bool "python-libconfig"
> +       depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> +  select BR2_PACKAGE_BOOST_PYTHON

 You should also select BR2_PACKAGE_BOOST.

 You should also depend on boost's toolchain dependencies:
BR2_INSTALL_LIBSTDCPP, BR2_LARGEFILE, BR2_TOOLCHAIN_HAS_THREADS, and add
the corresponding comment.

 It's a crying shame that the python wrapper for something trivial like
libconfig requires bloatware like boost :-) but that can't be helped of
course.

> +       select BR2_PACKAGE_LIBCONFIG
> +       help
> +           Python bindings to the C++ library libconfig

 Perhaps add a bit of the help text of libconfig.

 Regards,
 Arnout

> +
> +          https://github.com/cnangel/python-libconfig
> diff --git a/package/python-libconfig/python-libconfig.mk b/package/python-libconfig/python-libconfig.mk
> new file mode 100644
> index 0000000..8d597ef
> --- /dev/null
> +++ b/package/python-libconfig/python-libconfig.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# python-libconfig
> +#
> +################################################################################
> +
> +PYTHON_LIBCONFIG_VERSION = b271c3d9dac938ad5cd29b67bd08cc5536a5a391
> +PYTHON_LIBCONFIG_SITE = https://github.com/cnangel/python-libconfig/
> +PYTHON_LIBCONFIG_SITE_METHOD = git
> +
> +PYTHON_LIBCONFIG_LICENSE = BSD
> +PYTHON_LIBCONFIG_LICENSE_FILES = README
> +
> +PYTHON_LIBCONFIG_SETUP_TYPE = setuptools
> +
> +PYTHON_LIBCONFIG_DEPENDENCIES = libconfig boost
> +
> +$(eval $(python-package))
> +
> +
> +
> --
> 1.7.10.4
> 
> Best regards,
> Johan Derycke
> 
> 
> 
> 
> 
> This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
>
Arnout Vandecappelle March 6, 2014, 5:26 p.m. UTC | #3 
On 06/03/14 10:05, Derycke, Johan wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Arnout Vandecappelle [mailto:arnout@mind.be]
>> Sent: woensdag 5 maart 2014 18:11
>> To: Derycke, Johan; buildroot@busybox.net
>> Subject: Re: [Buildroot] [PATCH 1/2] python-libconfig: new package
>>
>> On 04/03/14 09:32, Derycke, Johan wrote:
>>> Python bindings to the C++ library libconfig
>>> https://github.com/cnangel/python-libconfig
>>>
>>> Signed-off-by: Johan Derycke <johan.derycke@barco.com>
>>> ---
>>>  package/python-libconfig/Config.in           |    9 +++++++++
>>>  package/python-libconfig/python-libconfig.mk |   21
>> +++++++++++++++++++++
>>>  2 files changed, 30 insertions(+)
>>>  create mode 100644 package/python-libconfig/Config.in
>>>  create mode 100644 package/python-libconfig/python-libconfig.mk
>>>
>>> diff --git a/package/python-libconfig/Config.in
>>> b/package/python-libconfig/Config.in
>>> new file mode 100644
>>> index 0000000..7e4f317
>>> --- /dev/null
>>> +++ b/package/python-libconfig/Config.in
>>> @@ -0,0 +1,9 @@
>>> +config BR2_PACKAGE_PYTHON_LIBCONFIG
>>> +       bool "python-libconfig"
>>> +       depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
>>> +  select BR2_PACKAGE_BOOST_PYTHON
>>
>>  You should also select BR2_PACKAGE_BOOST.
>>
>>  You should also depend on boost's toolchain dependencies:
>> BR2_INSTALL_LIBSTDCPP, BR2_LARGEFILE, BR2_TOOLCHAIN_HAS_THREADS,
>> and add the corresponding comment.
> 
> Can I use:
> 
> comment "python libconfig needs boost"
>         depends on !BR2_PACKAGE_BOOST
>         depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
> 
> to avoid the boost "bloatware" being installed behind the back?

 No, that's OK. The bloat is only in the source, not in the libary (I
haven't built it yet but I expect it will be in the order of 100K).

 I mainly made the remark to trigger you to consider if it is really
needed. But I think I get it now: boost.Python is an alternative for
something like swig or sip. I first thought it was using some of boost's
standard C++ library alternatives.


 Regards,
 Arnout

> 
>>
>>  It's a crying shame that the python wrapper for something trivial like libconfig
>> requires bloatware like boost :-) but that can't be helped of course.
>>
>>> +       select BR2_PACKAGE_LIBCONFIG
>>> +       help
>>> +           Python bindings to the C++ library libconfig
>>
>>  Perhaps add a bit of the help text of libconfig.
>>
>>  Regards,
>>  Arnout

[snip]
diff mbox

Patch

diff --git a/package/python-libconfig/Config.in b/package/python-libconfig/Config.in
new file mode 100644
index 0000000..7e4f317
--- /dev/null
+++ b/package/python-libconfig/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_PYTHON_LIBCONFIG
+       bool "python-libconfig"
+       depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+  select BR2_PACKAGE_BOOST_PYTHON
+       select BR2_PACKAGE_LIBCONFIG
+       help
+           Python bindings to the C++ library libconfig
+
+          https://github.com/cnangel/python-libconfig
diff --git a/package/python-libconfig/python-libconfig.mk b/package/python-libconfig/python-libconfig.mk
new file mode 100644
index 0000000..8d597ef
--- /dev/null
+++ b/package/python-libconfig/python-libconfig.mk
@@ -0,0 +1,21 @@ 
+################################################################################
+#
+# python-libconfig
+#
+################################################################################
+
+PYTHON_LIBCONFIG_VERSION = b271c3d9dac938ad5cd29b67bd08cc5536a5a391
+PYTHON_LIBCONFIG_SITE = https://github.com/cnangel/python-libconfig/
+PYTHON_LIBCONFIG_SITE_METHOD = git
+
+PYTHON_LIBCONFIG_LICENSE = BSD
+PYTHON_LIBCONFIG_LICENSE_FILES = README
+
+PYTHON_LIBCONFIG_SETUP_TYPE = setuptools
+
+PYTHON_LIBCONFIG_DEPENDENCIES = libconfig boost
+
+$(eval $(python-package))
+
+
+