From patchwork Mon Aug 31 07:03:32 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: mtd: onenand: use KERN_DEBUG for ECC errors Date: Sun, 30 Aug 2009 21:03:32 -0000 From: Artem Bityutskiy X-Patchwork-Id: 32611 Message-Id: <1251702212-17785-1-git-send-email-dedekind@infradead.org> To: linux-mtd@lists.infradead.org Cc: Kyungmin Park , Adrian Hunter From: Artem Bityutskiy ECC errors is a normal phenomena on OneNAND and they happen quite often. Flash-aware file-systems like JFFS2 or UBIFS are able to handle them gracefully. Currently OneNAND driver prints about ECC errors like this: onenand_bbt_wait: ecc error = 0x2222, controller error 0x2400 onenand_bbt_wait: ecc error = 0x2222, controller error 0x2400 onenand_bbt_wait: ecc error = 0x2222, controller error 0x2400 These messages are scary and make users think that something serious happened. However, they are handled nicely by UBIFS. This patch makes this messages to be printed with KERN_DEBUG level, so that they would not go to the console, at least, which is currently happening in case of standard default setup. Indeed, since ECC errors are supposed to be handled by upper level SW, we do not really have to print these messages, and we may consider them as debugging prints. Signed-off-by: Artem Bityutskiy --- drivers/mtd/onenand/onenand_base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 6e82909..994939e 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -1450,7 +1450,7 @@ static int onenand_bbt_wait(struct mtd_info *mtd, int state) if (interrupt & ONENAND_INT_READ) { int ecc = onenand_read_ecc(this); if (ecc & ONENAND_ECC_2BIT_ALL) { - printk(KERN_INFO "onenand_bbt_wait: ecc error = 0x%04x" + printk(KERN_DEBUG "onenand_bbt_wait: ecc error = 0x%04x" ", controller error 0x%04x\n", ecc, ctrl); return ONENAND_BBT_READ_ECC_ERROR; }