Patchwork [1/2] ext4: fix wrong assert in ext4_mb_normalize_request()

login
register
mail settings
Submitter Maurizio Lombardi
Date March 3, 2014, 2 p.m.
Message ID <1393855228-13592-2-git-send-email-mlombard@redhat.com>
Download mbox | patch
Permalink /patch/325842/
State Awaiting Upstream
Headers show

Comments

Maurizio Lombardi - March 3, 2014, 2 p.m.
the variable "size" is expressed as number of blocks and not as
number of clusters, this could trigger a kernel panic when using
ext4 with the size of a cluster different from the size of a block.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 fs/ext4/mballoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Theodore Ts'o - May 26, 2014, 4:42 p.m.
On Mon, Mar 03, 2014 at 03:00:27PM +0100, Maurizio Lombardi wrote:
> the variable "size" is expressed as number of blocks and not as
> number of clusters, this could trigger a kernel panic when using
> ext4 with the size of a cluster different from the size of a block.
> 
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 04a5c75..08ddfda 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3135,7 +3135,7 @@  ext4_mb_normalize_request(struct ext4_allocation_context *ac,
 	}
 	BUG_ON(start + size <= ac->ac_o_ex.fe_logical &&
 			start > ac->ac_o_ex.fe_logical);
-	BUG_ON(size <= 0 || size > EXT4_CLUSTERS_PER_GROUP(ac->ac_sb));
+	BUG_ON(size <= 0 || size > EXT4_BLOCKS_PER_GROUP(ac->ac_sb));
 
 	/* now prepare goal request */