Patchwork [v5,4/4] mtd: devices: elm: update DRIVER_NAME as "omap-elm"

login
register
mail settings
Submitter pekon gupta
Date March 3, 2014, 11:19 a.m.
Message ID <1393845563-7800-5-git-send-email-pekon@ti.com>
Download mbox | patch
Permalink /patch/325794/
State New
Headers show

Comments

pekon gupta - March 3, 2014, 11:19 a.m.
use "omap-elm" as DRIVER_NAME
prefix DRIVER_NAME in debug and error messages

Signed-off-by: Pekon Gupta <pekon@ti.com>
---
 drivers/mtd/devices/elm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Brian Norris - March 20, 2014, 11 a.m.
On Mon, Mar 03, 2014 at 04:49:23PM +0530, Pekon Gupta wrote:
> use "omap-elm" as DRIVER_NAME
> prefix DRIVER_NAME in debug and error messages
> 
> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
>  drivers/mtd/devices/elm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
> index 43fd81d..16e62ae 100644
> --- a/drivers/mtd/devices/elm.c
> +++ b/drivers/mtd/devices/elm.c
> @@ -15,6 +15,9 @@
>   *
>   */
>  
> +#define	DRIVER_NAME	"omap-elm"

Your spacing is a little off. You have a tab between 'define' and
'DRIVER_NAME'.

> +#define pr_fmt(fmt)	DRIVER_NAME ": " fmt
> +
>  #include <linux/platform_device.h>
>  #include <linux/module.h>
>  #include <linux/interrupt.h>
> @@ -522,7 +525,7 @@ MODULE_DEVICE_TABLE(of, elm_of_match);
>  
>  static struct platform_driver elm_driver = {
>  	.driver	= {
> -		.name	= "elm",
> +		.name	= DRIVER_NAME,
>  		.owner	= THIS_MODULE,
>  		.of_match_table = of_match_ptr(elm_of_match),
>  		.pm	= &elm_pm_ops,

Brian

Patch

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index 43fd81d..16e62ae 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -15,6 +15,9 @@ 
  *
  */
 
+#define	DRIVER_NAME	"omap-elm"
+#define pr_fmt(fmt)	DRIVER_NAME ": " fmt
+
 #include <linux/platform_device.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>
@@ -522,7 +525,7 @@  MODULE_DEVICE_TABLE(of, elm_of_match);
 
 static struct platform_driver elm_driver = {
 	.driver	= {
-		.name	= "elm",
+		.name	= DRIVER_NAME,
 		.owner	= THIS_MODULE,
 		.of_match_table = of_match_ptr(elm_of_match),
 		.pm	= &elm_pm_ops,