diff mbox

net: convert one non-symbolic return value in dev_queue_xmit

Message ID 20090830062136.6299.31696.sendpatchset@localhost.localdomain
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Krishna Kumar Aug. 30, 2009, 6:21 a.m. UTC 
From: Krishna Kumar <krkumar2@in.ibm.com>

net: convert remaining non-symbolic return values in dev_queue_xmit

Patch compiled and 32 simultaneous netperf testing ran fine. 

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---

 net/core/dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Aug. 31, 2009, 5:18 a.m. UTC | #1 
From: Krishna Kumar <krkumar2@in.ibm.com>
Date: Sun, 30 Aug 2009 11:51:36 +0530

> From: Krishna Kumar <krkumar2@in.ibm.com>
> 
> net: convert remaining non-symbolic return values in dev_queue_xmit
> 
> Patch compiled and 32 simultaneous netperf testing ran fine. 
> 
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>

Applied, but please do me a favor.

Do not provide two commit message header lines like this.
They aren't even equal.

Whatever you give me in the Subject line after "[....] " is what
ends up being the commit message header line when I apply your
patch.

Adding another commit header line in your email message body just
makes the commit look confusing and ugly.

So just give me one in the subject line and elide the one in the
message body.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -ruNp org/net/core/dev.c new/net/core/dev.c
--- org/net/core/dev.c	2009-08-28 21:36:46.000000000 +0530
+++ new/net/core/dev.c	2009-08-28 21:40:36.000000000 +0530
@@ -1917,7 +1917,7 @@  gso:
 			HARD_TX_LOCK(dev, txq, cpu);
 
 			if (!netif_tx_queue_stopped(txq)) {
-				rc = 0;
+				rc = NET_XMIT_SUCCESS;
 				if (!dev_hard_start_xmit(skb, dev, txq)) {
 					HARD_TX_UNLOCK(dev, txq);
 					goto out;