| Message ID | 1393603865-26198-6-git-send-email-lczerner@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 2/28/14, 10:11 AM, Lukas Czerner wrote: > Translate flags in fiemap_f output to human readable strings. This looks fine, w/ the caveats about translate_flags that I mentioned on the earlier patch. Reviewed-by: Eric Sandeen <sandeen@redhat.com> > Signed-off-by: Lukas Czerner <lczerner@redhat.com> > --- > ltp/fsstress.c | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/ltp/fsstress.c b/ltp/fsstress.c > index 24864db..869a8ac 100644 > --- a/ltp/fsstress.c > +++ b/ltp/fsstress.c > @@ -2252,6 +2252,18 @@ fdatasync_f(int opno, long r) > free_pathname(&f); > close(fd); > } > + > +#ifdef HAVE_LINUX_FIEMAP_H > +struct print_flags fiemap_flags[] = { > + { FIEMAP_FLAG_SYNC, "SYNC"}, > + { FIEMAP_FLAG_XATTR, "XATTR"}, > + { -1, NULL} > +}; > + > +#define translate_fiemap_flags(mode) \ > + ({translate_flags(mode, "|", fiemap_flags);}) > +#endif > + > void > fiemap_f(int opno, long r) > { > @@ -2314,9 +2326,10 @@ fiemap_f(int opno, long r) > > e = ioctl(fd, FS_IOC_FIEMAP, (unsigned long)fiemap); > if (v) > - printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld %x %d\n", > + printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld (%s) %d\n", > procid, opno, f.path, st, (long long)fiemap->fm_start, > - (long long) fiemap->fm_length, fiemap->fm_flags, e); > + (long long) fiemap->fm_length, > + translate_fiemap_flags(fiemap->fm_flags), e); > free(fiemap); > free_pathname(&f); > close(fd); > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ltp/fsstress.c b/ltp/fsstress.c index 24864db..869a8ac 100644 --- a/ltp/fsstress.c +++ b/ltp/fsstress.c @@ -2252,6 +2252,18 @@ fdatasync_f(int opno, long r) free_pathname(&f); close(fd); } + +#ifdef HAVE_LINUX_FIEMAP_H +struct print_flags fiemap_flags[] = { + { FIEMAP_FLAG_SYNC, "SYNC"}, + { FIEMAP_FLAG_XATTR, "XATTR"}, + { -1, NULL} +}; + +#define translate_fiemap_flags(mode) \ + ({translate_flags(mode, "|", fiemap_flags);}) +#endif + void fiemap_f(int opno, long r) { @@ -2314,9 +2326,10 @@ fiemap_f(int opno, long r) e = ioctl(fd, FS_IOC_FIEMAP, (unsigned long)fiemap); if (v) - printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld %x %d\n", + printf("%d/%d: ioctl(FIEMAP) %s%s %lld %lld (%s) %d\n", procid, opno, f.path, st, (long long)fiemap->fm_start, - (long long) fiemap->fm_length, fiemap->fm_flags, e); + (long long) fiemap->fm_length, + translate_fiemap_flags(fiemap->fm_flags), e); free(fiemap); free_pathname(&f); close(fd);
Translate flags in fiemap_f output to human readable strings. Signed-off-by: Lukas Czerner <lczerner@redhat.com> --- ltp/fsstress.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)