| Message ID | 20140228121347.GA38696@msticlxl57.ims.intel.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Feb 28, 2014 at 1:14 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote: > Hello, > This is relatively obvious patch which eliminates comparision > of inifinities for exp2 AVX-512 test and properly comparing floats > for avx512f-sqrtps-2.c. > > Tests pass. > > Is it ok for trunk? > > gcc/testsuite/ > * gcc.target/i386/avx512er-vexp2ps-2.c: Decrease exponent > argument to avoid inf values. > * gcc.target/i386/avx512er-vexp2ps-2.c: Compare results with > UNION_FP_CHECK machinery. You are talking about avx512f-sqrtps-2.c, the ChangeLog refers to avx512er-vexp2ps-2.c, but the patch is modifying avx512f-vdivps-2.c. Uros.
Hello Uroš, On 28 Feb 13:55, Uros Bizjak wrote: > On Fri, Feb 28, 2014 at 1:14 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote: > > Hello, > > This is relatively obvious patch which eliminates comparision > > of inifinities for exp2 AVX-512 test and properly comparing floats > > for avx512f-sqrtps-2.c. > > > > Tests pass. > > > > Is it ok for trunk? > > > > gcc/testsuite/ > > * gcc.target/i386/avx512er-vexp2ps-2.c: Decrease exponent > > argument to avoid inf values. > > * gcc.target/i386/avx512er-vexp2ps-2.c: Compare results with > > UNION_FP_CHECK machinery. > > You are talking about avx512f-sqrtps-2.c, the ChangeLog refers to > avx512er-vexp2ps-2.c, but the patch is modifying avx512f-vdivps-2.c. Sorry for mess. Broken was avx512f-vdivps-2.c. Updated testsuite/CHangelog: * gcc.target/i386/avx512er-vexp2ps-2.c: Decrease exponent argument to avoid inf values. * gcc.target/i386/avx512f-vdivps-2.c: Compare results with UNION_FP_CHECK machinery. -- Thanks, K
On Sat, Mar 1, 2014 at 7:13 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote: > Hello Uroš, > On 28 Feb 13:55, Uros Bizjak wrote: >> On Fri, Feb 28, 2014 at 1:14 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote: >> > Hello, >> > This is relatively obvious patch which eliminates comparision >> > of inifinities for exp2 AVX-512 test and properly comparing floats >> > for avx512f-sqrtps-2.c. >> > >> > Tests pass. >> > >> > Is it ok for trunk? >> > >> > gcc/testsuite/ >> > * gcc.target/i386/avx512er-vexp2ps-2.c: Decrease exponent >> > argument to avoid inf values. >> > * gcc.target/i386/avx512er-vexp2ps-2.c: Compare results with >> > UNION_FP_CHECK machinery. >> >> You are talking about avx512f-sqrtps-2.c, the ChangeLog refers to >> avx512er-vexp2ps-2.c, but the patch is modifying avx512f-vdivps-2.c. > Sorry for mess. > Broken was avx512f-vdivps-2.c. > > Updated testsuite/CHangelog: > * gcc.target/i386/avx512er-vexp2ps-2.c: Decrease exponent > argument to avoid inf values. > * gcc.target/i386/avx512f-vdivps-2.c: Compare results with > UNION_FP_CHECK machinery. OK. Thanks, Uros.
diff --git a/gcc/testsuite/gcc.target/i386/avx512er-vexp2ps-2.c b/gcc/testsuite/gcc.target/i386/avx512er-vexp2ps-2.c index 06ef68c..ab911c0 100644 --- a/gcc/testsuite/gcc.target/i386/avx512er-vexp2ps-2.c +++ b/gcc/testsuite/gcc.target/i386/avx512er-vexp2ps-2.c @@ -25,7 +25,7 @@ avx512er_test (void) for (i = 0; i < 16; i++) { - src.a[i] = 179.345 - 6.5645 * i; + src.a[i] = 79.345 - 6.5645 * i; res2.a[i] = DEFAULT_VALUE; } diff --git a/gcc/testsuite/gcc.target/i386/avx512f-vdivps-2.c b/gcc/testsuite/gcc.target/i386/avx512f-vdivps-2.c index 5249bbd..f5a7b78 100644 --- a/gcc/testsuite/gcc.target/i386/avx512f-vdivps-2.c +++ b/gcc/testsuite/gcc.target/i386/avx512f-vdivps-2.c @@ -46,10 +46,10 @@ TEST (void) abort (); MASK_MERGE () (res_ref, mask, SIZE); - if (UNION_CHECK (AVX512F_LEN,) (res2, res_ref)) + if (UNION_FP_CHECK (AVX512F_LEN,) (res2, res_ref)) abort (); MASK_ZERO () (res_ref, mask, SIZE); - if (UNION_CHECK (AVX512F_LEN,) (res3, res_ref)) + if (UNION_FP_CHECK (AVX512F_LEN,) (res3, res_ref)) abort ();