From patchwork Sat Aug 29 18:56:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 32508 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 019EFB7B63 for ; Sun, 30 Aug 2009 04:50:54 +1000 (EST) Received: by ozlabs.org (Postfix) id D4134DDD0C; Sun, 30 Aug 2009 04:50:53 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 0EADEDDD0B for ; Sun, 30 Aug 2009 04:50:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbZH2Suo (ORCPT ); Sat, 29 Aug 2009 14:50:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752397AbZH2Suo (ORCPT ); Sat, 29 Aug 2009 14:50:44 -0400 Received: from mail-ew0-f206.google.com ([209.85.219.206]:37413 "EHLO mail-ew0-f206.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbZH2Sun (ORCPT ); Sat, 29 Aug 2009 14:50:43 -0400 Received: by ewy2 with SMTP id 2so2973749ewy.17 for ; Sat, 29 Aug 2009 11:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=olORXX/n+vju48suJlIR5OGp21MfTkzuJkDGhaA1s2s=; b=tkSPopBjXQMY1ByseGyUNi0xRSX8UyWuzK+faGisuFoGG4FPUOor/S141/Pr8NH+GX GSLRSZrLsDG76bWZbC6mZhY+mAnZju5PD3ytYcBLo2cbgi0sIqUAAnh5rvtg5p9AQO73 tW/Hz6DxZId+BSoMIHvwiOpzI8xpWWcyt5xYo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=ccwK4FMP166hb1kdJC63JTX7/vERLD436x0+bEZtyhCnbZ9K/MwBvew4uv46EVP8xh MlTbJmE1aS4polsKWEHtBe1VpuTJ1wjowNPtWde3jlBtHc0iPy5zoyaZdmMeNrUBlA0A k+hImJa73SAAgeGDpxUBRM4n2kAvM1/O6qw+k= Received: by 10.211.128.9 with SMTP id f9mr2949079ebn.93.1251571844751; Sat, 29 Aug 2009 11:50:44 -0700 (PDT) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 28sm578266eyg.29.2009.08.29.11.50.43 (version=SSLv3 cipher=RC4-MD5); Sat, 29 Aug 2009 11:50:43 -0700 (PDT) Message-ID: <4A9979CC.2090905@gmail.com> Date: Sat, 29 Aug 2009 20:56:12 +0200 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Chas Williams , linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Andrew Morton Subject: [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group() Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org he_dev->rbps_virt allocation may fail. Signed-off-by: Roel Kluin --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/atm/he.c b/drivers/atm/he.c index 2de6406..2d766d6 100644 --- a/drivers/atm/he.c +++ b/drivers/atm/he.c @@ -795,6 +795,8 @@ he_init_group(struct he_dev *he_dev, int group) } memset(he_dev->rbps_base, 0, CONFIG_RBPS_SIZE * sizeof(struct he_rbp)); he_dev->rbps_virt = kmalloc(CONFIG_RBPS_SIZE * sizeof(struct he_virt), GFP_KERNEL); + if (he_dev->rbps_virt == NULL) + return -ENOMEM; for (i = 0; i < CONFIG_RBPS_SIZE; ++i) { dma_addr_t dma_handle;