Patchwork inappropriate pending block in foldchain

login
register
mail settings
Submitter Mohanlal Jangir
Date Aug. 29, 2009, 10:17 a.m.
Message ID <58484c0e0908290317m62485b2bu6ca69db7de8111a5@mail.gmail.com>
Download mbox | patch
Permalink /patch/32495/
State New
Headers show

Comments

Mohanlal Jangir - Aug. 29, 2009, 10:17 a.m.
In function  INFTL_findwriteunit, inappropriate pending block
parameter is passed which prevents 0xFFFF block copy during foldchain.
This patch fixes the problem.

-Mohan
Artem Bityutskiy - Sept. 1, 2009, 9:04 a.m.
On Sat, 2009-08-29 at 19:17 +0900, Mohanlal Jangir wrote:
> In function  INFTL_findwriteunit, inappropriate pending block
> parameter is passed which prevents 0xFFFF block copy during foldchain.
> This patch fixes the problem.

I could not find your signed-off-by line.
Artem Bityutskiy - Sept. 1, 2009, 9:07 a.m.
On Sat, 2009-08-29 at 19:17 +0900, Mohanlal Jangir wrote:
> In function  INFTL_findwriteunit, inappropriate pending block
> parameter is passed which prevents 0xFFFF block copy during foldchain.
> This patch fixes the problem.
> 
> -Mohan
> 
> diff -Nur a/linux-2.6.30.5/drivers/mtd/inftlcore.c
> b/linux-2.6.30.5/drivers/mtd/inftlcore.c
> --- a/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-17 06:19:38.000000000 +0900
> +++ b/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-29 19:04:21.953125000 +0900
> @@ -549,7 +549,7 @@
>      * waiting to be picked up. We're going to have to fold
>      * a chain to make room.
>      */
> -   thisEUN = INFTL_makefreeblock(inftl, 0xffff);
> +   thisEUN = INFTL_makefreeblock(inftl, block);

I cannot apply your patch. Please, send the patch to yourself first,
make sure you can save it and apply using 'git am', and when it works,
send it to the mailing list.

Hint: we use "git format-patch" to create patches.

Thanks.

Patch

diff -Nur a/linux-2.6.30.5/drivers/mtd/inftlcore.c
b/linux-2.6.30.5/drivers/mtd/inftlcore.c
--- a/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-17 06:19:38.000000000 +0900
+++ b/linux-2.6.30.5/drivers/mtd/inftlcore.c 2009-08-29 19:04:21.953125000 +0900
@@ -549,7 +549,7 @@ 
     * waiting to be picked up. We're going to have to fold
     * a chain to make room.
     */
-   thisEUN = INFTL_makefreeblock(inftl, 0xffff);
+   thisEUN = INFTL_makefreeblock(inftl, block);

    /*
     * Hopefully we free something, lets try again.