From patchwork Thu Feb 27 08:43:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 324733 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2F87A2C0099 for ; Thu, 27 Feb 2014 19:43:47 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=MxXaZayB0svgs+W/lc zociVJTvXKP5PR4a46QwDg1MbZ9Qr5yV+5D7SlvdvVR462sHUgbvqYBm0Rpfmzhb ROP6OaIIqZX4PrjjB+bDe2g+Rgeu2sbwLMWjyafaJSVFXjN0VFVynm0aEdIliY1P p19WSz/sinQ7X9ps5DF5SUpZI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=CcCTPU6MYV6MKFAxYODDqEiB 8bA=; b=eLTy8weSoiGW4KFv95PcJpyCPcxviNdBqY9ROAddCUhuszI5En9Il3u0 VelmGa3dBJeLAIcC17fsdrMnL/x+HpF+8q06B0dHkpeRiM159ecQ53du4PLlZcZ2 PMZFUDyF8xVmFU9k5pbwvNTYi8kxoddTKquLGseXQ/Qep6YGzYA= Received: (qmail 11330 invoked by alias); 27 Feb 2014 08:43:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11301 invoked by uid 89); 27 Feb 2014 08:43:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f182.google.com Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 27 Feb 2014 08:43:38 +0000 Received: by mail-wi0-f182.google.com with SMTP id f8so3150839wiw.15 for ; Thu, 27 Feb 2014 00:43:35 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.165.238 with SMTP id zb14mr8282442wib.51.1393490614820; Thu, 27 Feb 2014 00:43:34 -0800 (PST) Received: by 10.194.62.111 with HTTP; Thu, 27 Feb 2014 00:43:34 -0800 (PST) In-Reply-To: <530E6857.2060801@net-b.de> References: <53086730.5090500@net-b.de> <530E6857.2060801@net-b.de> Date: Thu, 27 Feb 2014 09:43:34 +0100 Message-ID: Subject: Re: PR60147: fix ICE with DECL_NAMELIST and tree-pretty-printer.c From: Richard Biener To: Tobias Burnus Cc: gcc-patches X-IsSubscribed: yes On Wed, Feb 26, 2014 at 11:19 PM, Tobias Burnus wrote: > Dear all, > > as suggested by Richard, it now only prints the namelist name and no longer > the variables of the namelist. > > Bootstrapped on x86-64-gnu-linux and currently regtesting. > OK for the trunk when it succeeds? Works for me, but doesn't the simpler also work? It's odd that we need to do sth special just for namelist-decls. Richard. > Tobias > > > On February 22, 2014 10:00, Tobias Burnus wrote: >> >> Since GCC 4.9, gfortran generates a DECL_NAMELIST (for DWARF's >> DW_TAG_namelist) - they are stored in the BIND_EXPR. Namelists are a bit >> boring: They only group variable names and the namelist name is only used in >> I/O statements (READ, WRITE) to permit a fancy data input [and output] - and >> for the debugger. >> >> Due to DW_TAG_namelist, namelists are now exposed to the middle end - and >> I forgot to handle them also in the tree pretty printer - hence >> -fdump-tree-original now ICEs. >> >> For the pretty printer one has two options: Ignoring (or "NYI;") the decl >> or dumping it. The attached patch does the latter. >> >> Bootstrapped (C/C++/Fortran) and regtested on x86-64-gnu-linux. >> OK for the trunk? >> >> Tobias Index: tree-pretty-print.c =================================================================== --- tree-pretty-print.c (revision 208066) +++ tree-pretty-print.c (working copy) @@ -1390,6 +1390,7 @@ case FIELD_DECL: case DEBUG_EXPR_DECL: case NAMESPACE_DECL: + case NAMELIST_DECL: dump_decl_name (buffer, node, flags); break;