Patchwork [1/2] ARM: SAMSUNG: remove gpio flags in dev-backlight

login
register
mail settings
Submitter Alexandre Courbot
Date Feb. 27, 2014, 5:53 a.m.
Message ID <1393480414-19473-2-git-send-email-acourbot@nvidia.com>
Download mbox | patch
Permalink /patch/324689/
State Accepted
Headers show

Comments

Alexandre Courbot - Feb. 27, 2014, 5:53 a.m.
The pwm-backlight driver is moving to use the gpiod interface,
which has its own mapping mechanism for platform data GPIOs.
These mappings carry GPIO properties like active low so they don't have
to be explicitly handled by GPIO consumers.

Because of this change, the enable_gpio_flags member of
platform_pwm_backlight_data is going away. dev-backlight was passing
this member, but had no user making use of it, so it can safely be
removed. Further GPIOs used by pwm-backlight are expected to be
defined using the mechanisms provided by the gpiod API.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm/plat-samsung/dev-backlight.c | 2 --
 1 file changed, 2 deletions(-)
Alexandre Courbot - April 10, 2014, 4:17 a.m.
Ping, can I have the Samsung folks review and ,aybe even merge this
patch? enable_gpio_flags is never used in any code, is replaced by
gpiod, and we would like to remove it altogether from pwm_bl. Thanks!

Alex.

On Thu, Feb 27, 2014 at 2:53 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> The pwm-backlight driver is moving to use the gpiod interface,
> which has its own mapping mechanism for platform data GPIOs.
> These mappings carry GPIO properties like active low so they don't have
> to be explicitly handled by GPIO consumers.
>
> Because of this change, the enable_gpio_flags member of
> platform_pwm_backlight_data is going away. dev-backlight was passing
> this member, but had no user making use of it, so it can safely be
> removed. Further GPIOs used by pwm-backlight are expected to be
> defined using the mechanisms provided by the gpiod API.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>  arch/arm/plat-samsung/dev-backlight.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c
> index be4ad0b21c08..2157c5b539e6 100644
> --- a/arch/arm/plat-samsung/dev-backlight.c
> +++ b/arch/arm/plat-samsung/dev-backlight.c
> @@ -124,8 +124,6 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
>                 samsung_bl_data->pwm_period_ns = bl_data->pwm_period_ns;
>         if (bl_data->enable_gpio >= 0)
>                 samsung_bl_data->enable_gpio = bl_data->enable_gpio;
> -       if (bl_data->enable_gpio_flags)
> -               samsung_bl_data->enable_gpio_flags = bl_data->enable_gpio_flags;
>         if (bl_data->init)
>                 samsung_bl_data->init = bl_data->init;
>         if (bl_data->notify)
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jingoo Han - April 10, 2014, 9:51 a.m.
On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
> 
> Ping, can I have the Samsung folks review and ,aybe even merge this
> patch? enable_gpio_flags is never used in any code, is replaced by
> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!

OK, I see. It looks good.

As far as I know, 'enable_gpio_flags' has not been being used
for Samsung platform. So, there will be no side effect,
if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
directory.

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> 
> Alex.
> 
> On Thu, Feb 27, 2014 at 2:53 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> > The pwm-backlight driver is moving to use the gpiod interface,
> > which has its own mapping mechanism for platform data GPIOs.
> > These mappings carry GPIO properties like active low so they don't have
> > to be explicitly handled by GPIO consumers.
> >
> > Because of this change, the enable_gpio_flags member of
> > platform_pwm_backlight_data is going away. dev-backlight was passing
> > this member, but had no user making use of it, so it can safely be
> > removed. Further GPIOs used by pwm-backlight are expected to be
> > defined using the mechanisms provided by the gpiod API.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> > ---
> >  arch/arm/plat-samsung/dev-backlight.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c
> > index be4ad0b21c08..2157c5b539e6 100644
> > --- a/arch/arm/plat-samsung/dev-backlight.c
> > +++ b/arch/arm/plat-samsung/dev-backlight.c
> > @@ -124,8 +124,6 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
> >                 samsung_bl_data->pwm_period_ns = bl_data->pwm_period_ns;
> >         if (bl_data->enable_gpio >= 0)
> >                 samsung_bl_data->enable_gpio = bl_data->enable_gpio;
> > -       if (bl_data->enable_gpio_flags)
> > -               samsung_bl_data->enable_gpio_flags = bl_data->enable_gpio_flags;
> >         if (bl_data->init)
> >                 samsung_bl_data->init = bl_data->init;
> >         if (bl_data->notify)
> > --
> > 1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre Courbot - April 10, 2014, 2:14 p.m.
On Thu, Apr 10, 2014 at 6:51 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
>>
>> Ping, can I have the Samsung folks review and ,aybe even merge this
>> patch? enable_gpio_flags is never used in any code, is replaced by
>> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!
>
> OK, I see. It looks good.
>
> As far as I know, 'enable_gpio_flags' has not been being used
> for Samsung platform. So, there will be no side effect,
> if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
> directory.
>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Great, thanks. Ben, Kukjin, could we have your Acked-by?

Thierry, if the Samsung maintainers are ok with it, and 2/2 of this
series is also ok for you (you merged the same for simple-panel
already), can you take both into your tree?

Thanks,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre Courbot - April 21, 2014, 6:07 a.m.
On Thu, Apr 10, 2014 at 11:14 PM, Alexandre Courbot <gnurou@gmail.com> wrote:
> On Thu, Apr 10, 2014 at 6:51 PM, Jingoo Han <jg1.han@samsung.com> wrote:
>> On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
>>>
>>> Ping, can I have the Samsung folks review and ,aybe even merge this
>>> patch? enable_gpio_flags is never used in any code, is replaced by
>>> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!
>>
>> OK, I see. It looks good.
>>
>> As far as I know, 'enable_gpio_flags' has not been being used
>> for Samsung platform. So, there will be no side effect,
>> if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
>> directory.
>>
>> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>
> Great, thanks. Ben, Kukjin, could we have your Acked-by?
>
> Thierry, if the Samsung maintainers are ok with it, and 2/2 of this
> series is also ok for you (you merged the same for simple-panel
> already), can you take both into your tree?

Last call - could we have a Acked-by from Ben or Kukjin and merge this
through Thierry's tree? Otherwise I will just have to drop this
series, which would be sad.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kukjin Kim - May 6, 2014, 4:59 a.m.
Alexandre Courbot wrote:
> 
> On Thu, Apr 10, 2014 at 11:14 PM, Alexandre Courbot <gnurou@gmail.com>
> wrote:
> > On Thu, Apr 10, 2014 at 6:51 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> >> On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
> >>>
> >>> Ping, can I have the Samsung folks review and ,aybe even merge this
> >>> patch? enable_gpio_flags is never used in any code, is replaced by
> >>> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!
> >>
> >> OK, I see. It looks good.
> >>
> >> As far as I know, 'enable_gpio_flags' has not been being used
> >> for Samsung platform. So, there will be no side effect,
> >> if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
> >> directory.
> >>
> >> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> > Great, thanks. Ben, Kukjin, could we have your Acked-by?
> >
> > Thierry, if the Samsung maintainers are ok with it, and 2/2 of this
> > series is also ok for you (you merged the same for simple-panel
> > already), can you take both into your tree?
> 
> Last call - could we have a Acked-by from Ben or Kukjin and merge this
> through Thierry's tree? Otherwise I will just have to drop this
> series, which would be sad.

Very sorry for late response. I missed... :(

Looks good to me, so please go ahead with my ack.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexandre Courbot - May 6, 2014, 2:33 p.m.
On Tue, May 6, 2014 at 1:59 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Alexandre Courbot wrote:
>>
>> On Thu, Apr 10, 2014 at 11:14 PM, Alexandre Courbot <gnurou@gmail.com>
>> wrote:
>> > On Thu, Apr 10, 2014 at 6:51 PM, Jingoo Han <jg1.han@samsung.com> wrote:
>> >> On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
>> >>>
>> >>> Ping, can I have the Samsung folks review and ,aybe even merge this
>> >>> patch? enable_gpio_flags is never used in any code, is replaced by
>> >>> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!
>> >>
>> >> OK, I see. It looks good.
>> >>
>> >> As far as I know, 'enable_gpio_flags' has not been being used
>> >> for Samsung platform. So, there will be no side effect,
>> >> if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
>> >> directory.
>> >>
>> >> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
>> >
>> > Great, thanks. Ben, Kukjin, could we have your Acked-by?
>> >
>> > Thierry, if the Samsung maintainers are ok with it, and 2/2 of this
>> > series is also ok for you (you merged the same for simple-panel
>> > already), can you take both into your tree?
>>
>> Last call - could we have a Acked-by from Ben or Kukjin and merge this
>> through Thierry's tree? Otherwise I will just have to drop this
>> series, which would be sad.
>
> Very sorry for late response. I missed... :(
>
> Looks good to me, so please go ahead with my ack.

Thanks Kukjin!

Thierry, do you want me to rebase and resend these (now old) patches?
I haven't heard anything from you about them yet.

Cheers,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-pwm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thierry Reding - May 6, 2014, 3:17 p.m.
On Tue, May 06, 2014 at 11:33:00PM +0900, Alexandre Courbot wrote:
> On Tue, May 6, 2014 at 1:59 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Alexandre Courbot wrote:
> >>
> >> On Thu, Apr 10, 2014 at 11:14 PM, Alexandre Courbot <gnurou@gmail.com>
> >> wrote:
> >> > On Thu, Apr 10, 2014 at 6:51 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> >> >> On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
> >> >>>
> >> >>> Ping, can I have the Samsung folks review and ,aybe even merge this
> >> >>> patch? enable_gpio_flags is never used in any code, is replaced by
> >> >>> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!
> >> >>
> >> >> OK, I see. It looks good.
> >> >>
> >> >> As far as I know, 'enable_gpio_flags' has not been being used
> >> >> for Samsung platform. So, there will be no side effect,
> >> >> if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
> >> >> directory.
> >> >>
> >> >> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >> >
> >> > Great, thanks. Ben, Kukjin, could we have your Acked-by?
> >> >
> >> > Thierry, if the Samsung maintainers are ok with it, and 2/2 of this
> >> > series is also ok for you (you merged the same for simple-panel
> >> > already), can you take both into your tree?
> >>
> >> Last call - could we have a Acked-by from Ben or Kukjin and merge this
> >> through Thierry's tree? Otherwise I will just have to drop this
> >> series, which would be sad.
> >
> > Very sorry for late response. I missed... :(
> >
> > Looks good to me, so please go ahead with my ack.
> 
> Thanks Kukjin!
> 
> Thierry, do you want me to rebase and resend these (now old) patches?
> I haven't heard anything from you about them yet.

No, that's fine. I can handle them.

Thanks,
Thierry
Thierry Reding - May 7, 2014, 8:14 a.m.
On Thu, Feb 27, 2014 at 02:53:33PM +0900, Alexandre Courbot wrote:
> The pwm-backlight driver is moving to use the gpiod interface,
> which has its own mapping mechanism for platform data GPIOs.
> These mappings carry GPIO properties like active low so they don't have
> to be explicitly handled by GPIO consumers.
> 
> Because of this change, the enable_gpio_flags member of
> platform_pwm_backlight_data is going away. dev-backlight was passing
> this member, but had no user making use of it, so it can safely be
> removed. Further GPIOs used by pwm-backlight are expected to be
> defined using the mechanisms provided by the gpiod API.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
>  arch/arm/plat-samsung/dev-backlight.c | 2 --
>  1 file changed, 2 deletions(-)

Applied with Kukjin's Acked-by, thanks.

Thierry

Patch

diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c
index be4ad0b21c08..2157c5b539e6 100644
--- a/arch/arm/plat-samsung/dev-backlight.c
+++ b/arch/arm/plat-samsung/dev-backlight.c
@@ -124,8 +124,6 @@  void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
 		samsung_bl_data->pwm_period_ns = bl_data->pwm_period_ns;
 	if (bl_data->enable_gpio >= 0)
 		samsung_bl_data->enable_gpio = bl_data->enable_gpio;
-	if (bl_data->enable_gpio_flags)
-		samsung_bl_data->enable_gpio_flags = bl_data->enable_gpio_flags;
 	if (bl_data->init)
 		samsung_bl_data->init = bl_data->init;
 	if (bl_data->notify)