Patchwork video: pwm backlight: power off when necessary

login
register
mail settings
Submitter Liu Ying
Date Feb. 26, 2014, 11:39 a.m.
Message ID <1393414752-8861-1-git-send-email-Ying.Liu@freescale.com>
Download mbox | patch
Permalink /patch/324282/
State New
Headers show

Comments

Liu Ying - Feb. 26, 2014, 11:39 a.m.
The pwm backlight should be powered off only in two cases:
1) pwm polarity is normal and brightness is zero.
2) pwm polarity is inversed and brightness is maximal,
   that is, 100% duty.

This patch implements this logic in the pwm backlight driver
and actually fixes the issue that backlight is on when we
intend to set the brightness to be zero for an inversed pwm
signal.  The root cause of the issue is that power is off
in that case.

Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
 drivers/video/backlight/pwm_bl.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Patch

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index b75201f..e61e66a 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -100,6 +100,8 @@  static int compute_duty_cycle(struct pwm_bl_data *pb, int brightness)
 static int pwm_backlight_update_status(struct backlight_device *bl)
 {
 	struct pwm_bl_data *pb = bl_get_data(bl);
+	enum pwm_polarity polarity = pb->pwm->polarity;
+	int max = bl->props.max_brightness;
 	int brightness = bl->props.brightness;
 	int duty_cycle;
 
@@ -111,12 +113,14 @@  static int pwm_backlight_update_status(struct backlight_device *bl)
 	if (pb->notify)
 		brightness = pb->notify(pb->dev, brightness);
 
-	if (brightness > 0) {
+	if ((polarity == PWM_POLARITY_NORMAL && brightness == 0) ||
+	    (polarity == PWM_POLARITY_INVERSED && brightness == max)) {
+		pwm_backlight_power_off(pb);
+	} else {
 		duty_cycle = compute_duty_cycle(pb, brightness);
 		pwm_config(pb->pwm, duty_cycle, pb->period);
 		pwm_backlight_power_on(pb, brightness);
-	} else
-		pwm_backlight_power_off(pb);
+	}
 
 	if (pb->notify_after)
 		pb->notify_after(pb->dev, brightness);